From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50167)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SeQhI-00068G-QY
	for qemu-devel@nongnu.org; Tue, 12 Jun 2012 08:59:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SeQhC-00007T-Hk
	for qemu-devel@nongnu.org; Tue, 12 Jun 2012 08:59:48 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:37315)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SeQhC-00005I-49
	for qemu-devel@nongnu.org; Tue, 12 Jun 2012 08:59:42 -0400
Received: by pbbro12 with SMTP id ro12so809198pbb.4
	for <qemu-devel@nongnu.org>; Tue, 12 Jun 2012 05:59:39 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4FD73D35.7000000@redhat.com>
Date: Tue, 12 Jun 2012 14:59:33 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1339499796.git.phrdina@redhat.com>
	<83fb3a579f13cec8bd6a62a486911627f36e7185.1339499796.git.phrdina@redhat.com>
In-Reply-To: <83fb3a579f13cec8bd6a62a486911627f36e7185.1339499796.git.phrdina@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 4/4] fdc: fix interrupt handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Hrdina <phrdina@redhat.com>
Cc: qemu-devel@nongnu.org

Il 12/06/2012 13:19, Pavel Hrdina ha scritto:
>      } else {
> -        /* XXX: status0 handling is broken for read/write
> -           commands, so we do this hack. It should be suppressed
> -           ASAP */
> -        fdctrl->fifo[0] =
> -            FD_SR0_SEEK | (cur_drv->head << 2) | GET_CUR_DRV(fdctrl);
> +        fdctrl->fifo[0] = (fdctrl->status0 & ~FD_SR0_HEAD) | GET_CUR_DRV(fdctrl);

Should bit 0 be cleared also, before ORing GET_CUR_DRV(fdctrl)?

Paolo