qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] MIPS/system: MTC0 single-stepping PC update fix
Date: Tue, 12 Jun 2012 07:32:32 -0700	[thread overview]
Message-ID: <4FD75300.80602@twiddle.net> (raw)
In-Reply-To: <alpine.DEB.1.10.1206072316150.23962@tp.orcam.me.uk>

On 2012-06-07 18:05, Maciej W. Rozycki wrote:
>      if (env->singlestep_enabled && ctx.bstate != BS_BRANCH) {
> -        save_cpu_state(&ctx, ctx.bstate == BS_NONE);
> +        save_cpu_state(&ctx, ctx.bstate != BS_EXCP);
>          gen_helper_0i(raise_exception, EXCP_DEBUG);

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~

  reply	other threads:[~2012-06-12 14:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-08  1:05 [Qemu-devel] [PATCH] MIPS/system: MTC0 single-stepping PC update fix Maciej W. Rozycki
2012-06-12 14:32 ` Richard Henderson [this message]
2014-11-06 20:38 ` [Qemu-devel] [PATCH RESEND] mips: Ensure PC update with MTC0 single-stepping Maciej W. Rozycki
2014-11-07 10:42   ` Leon Alrae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FD75300.80602@twiddle.net \
    --to=rth@twiddle.net \
    --cc=aurelien@aurel32.net \
    --cc=macro@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).