From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43624)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1SeS9E-0007aM-R5
	for qemu-devel@nongnu.org; Tue, 12 Jun 2012 10:32:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1SeS98-0005UJ-Gm
	for qemu-devel@nongnu.org; Tue, 12 Jun 2012 10:32:44 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:53416)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1SeS98-0005TG-9k
	for qemu-devel@nongnu.org; Tue, 12 Jun 2012 10:32:38 -0400
Received: by yhoo21 with SMTP id o21so3949513yho.4
	for <qemu-devel@nongnu.org>; Tue, 12 Jun 2012 07:32:36 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4FD75300.80602@twiddle.net>
Date: Tue, 12 Jun 2012 07:32:32 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <alpine.DEB.1.10.1206072316150.23962@tp.orcam.me.uk>
In-Reply-To: <alpine.DEB.1.10.1206072316150.23962@tp.orcam.me.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] MIPS/system: MTC0 single-stepping PC
 update fix
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>

On 2012-06-07 18:05, Maciej W. Rozycki wrote:
>      if (env->singlestep_enabled && ctx.bstate != BS_BRANCH) {
> -        save_cpu_state(&ctx, ctx.bstate == BS_NONE);
> +        save_cpu_state(&ctx, ctx.bstate != BS_EXCP);
>          gen_helper_0i(raise_exception, EXCP_DEBUG);

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~