From: Richard Henderson <rth@twiddle.net>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] MIPS: Correct MIPS16/microMIPS branch size calculation
Date: Tue, 12 Jun 2012 08:01:27 -0700 [thread overview]
Message-ID: <4FD759C7.4090204@twiddle.net> (raw)
In-Reply-To: <alpine.DEB.1.10.1206080050430.23962@tp.orcam.me.uk>
On 2012-06-07 18:06, Maciej W. Rozycki wrote:
> "Use MIPS_HFLAG_B16 to determine the address of a jump instruction when we
> need to restart a delay slot instruction."
>
> and was not accompanied by a test case nor I have one offhand.
>
> However this change appears obviously correct to me, and the same
> calculation is already used in exception_resume_pc applied to ordinary,
> Debug and NMI exceptions. This code on the other hand applies to reset
> exceptions and instruction restarts in the context of I/O.
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
next prev parent reply other threads:[~2012-06-12 15:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 1:06 [Qemu-devel] [PATCH] MIPS: Correct MIPS16/microMIPS branch size calculation Maciej W. Rozycki
2012-06-12 15:01 ` Richard Henderson [this message]
2012-06-12 15:11 ` Peter Maydell
2014-11-07 20:05 ` [Qemu-devel] [PATCH v2] mips: " Maciej W. Rozycki
2014-11-17 11:26 ` Leon Alrae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD759C7.4090204@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=macro@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).