From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49702) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeSbD-0006Uw-8K for qemu-devel@nongnu.org; Tue, 12 Jun 2012 11:01:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SeSb6-0002rp-K2 for qemu-devel@nongnu.org; Tue, 12 Jun 2012 11:01:38 -0400 Received: from mail-gg0-f173.google.com ([209.85.161.173]:52623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeSb6-0002r6-DW for qemu-devel@nongnu.org; Tue, 12 Jun 2012 11:01:32 -0400 Received: by ggnp1 with SMTP id p1so3943279ggn.4 for ; Tue, 12 Jun 2012 08:01:30 -0700 (PDT) Sender: Richard Henderson Message-ID: <4FD759C7.4090204@twiddle.net> Date: Tue, 12 Jun 2012 08:01:27 -0700 From: Richard Henderson MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] MIPS: Correct MIPS16/microMIPS branch size calculation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Maciej W. Rozycki" Cc: qemu-devel@nongnu.org, Aurelien Jarno On 2012-06-07 18:06, Maciej W. Rozycki wrote: > "Use MIPS_HFLAG_B16 to determine the address of a jump instruction when we > need to restart a delay slot instruction." > > and was not accompanied by a test case nor I have one offhand. > > However this change appears obviously correct to me, and the same > calculation is already used in exception_resume_pc applied to ordinary, > Debug and NMI exceptions. This code on the other hand applies to reset > exceptions and instruction restarts in the context of I/O. Reviewed-by: Richard Henderson r~