From: Richard Henderson <rth@twiddle.net>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] MIPS/GDB: Correct stub handling of CP0 Status and Cause
Date: Tue, 12 Jun 2012 08:04:24 -0700 [thread overview]
Message-ID: <4FD75A78.7070401@twiddle.net> (raw)
In-Reply-To: <alpine.DEB.1.10.1206080111310.23962@tp.orcam.me.uk>
On 2012-06-07 18:07, Maciej W. Rozycki wrote:
> +/* Called for updates to CP0_Status. */
> +static inline void sync_c0_status(CPUMIPSState *env, int tc)
Any reason why these rather large functions are inline
rather than being in helper.c?
Otherwise, the change to gdbstub.c is most proper.
r~
prev parent reply other threads:[~2012-06-12 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 1:07 [Qemu-devel] [PATCH] MIPS/GDB: Correct stub handling of CP0 Status and Cause Maciej W. Rozycki
2012-06-12 15:04 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD75A78.7070401@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=macro@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).