From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeSeS-00087b-8Z for qemu-devel@nongnu.org; Tue, 12 Jun 2012 11:05:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SeSdy-0004xM-FO for qemu-devel@nongnu.org; Tue, 12 Jun 2012 11:04:59 -0400 Received: from mail-yw0-f45.google.com ([209.85.213.45]:56215) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeSdy-0004wA-8E for qemu-devel@nongnu.org; Tue, 12 Jun 2012 11:04:30 -0400 Received: by yhoo21 with SMTP id o21so3989485yho.4 for ; Tue, 12 Jun 2012 08:04:28 -0700 (PDT) Sender: Richard Henderson Message-ID: <4FD75A78.7070401@twiddle.net> Date: Tue, 12 Jun 2012 08:04:24 -0700 From: Richard Henderson MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] MIPS/GDB: Correct stub handling of CP0 Status and Cause List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Maciej W. Rozycki" Cc: qemu-devel@nongnu.org, Aurelien Jarno On 2012-06-07 18:07, Maciej W. Rozycki wrote: > +/* Called for updates to CP0_Status. */ > +static inline void sync_c0_status(CPUMIPSState *env, int tc) Any reason why these rather large functions are inline rather than being in helper.c? Otherwise, the change to gdbstub.c is most proper. r~