* [Qemu-devel] [PATCH] MIPS/GDB: Correct stub handling of CP1 FIR
@ 2012-06-08 1:08 Maciej W. Rozycki
2012-06-12 15:16 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Maciej W. Rozycki @ 2012-06-08 1:08 UTC (permalink / raw)
To: qemu-devel; +Cc: Maciej W. Rozycki, Aurelien Jarno
The CP1 FIR register is read-only, ignore any write attempts from the GDB
stub.
Signed-off-by: Maciej W. Rozycki <macro@codesourcery.com>
---
Definitely obvious, please apply.
Maciej
qemu-mips-fir.diff
Index: qemu-git-trunk/gdbstub.c
===================================================================
--- qemu-git-trunk.orig/gdbstub.c 2012-06-08 01:11:04.000000000 +0100
+++ qemu-git-trunk/gdbstub.c 2012-06-08 01:42:22.865584444 +0100
@@ -1130,7 +1130,9 @@ static int cpu_gdb_write_register(CPUMIP
/* set rounding mode */
RESTORE_ROUNDING_MODE;
break;
- case 71: env->active_fpu.fcr0 = tmp; break;
+ case 71:
+ /* FIR is read-only. Ignore writes. */
+ break;
}
return sizeof(target_ulong);
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] MIPS/GDB: Correct stub handling of CP1 FIR
2012-06-08 1:08 [Qemu-devel] [PATCH] MIPS/GDB: Correct stub handling of CP1 FIR Maciej W. Rozycki
@ 2012-06-12 15:16 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2012-06-12 15:16 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: qemu-devel, Aurelien Jarno
On 2012-06-07 18:08, Maciej W. Rozycki wrote:
> The CP1 FIR register is read-only, ignore any write attempts from the GDB
> stub.
>
> Signed-off-by: Maciej W. Rozycki <macro@codesourcery.com>
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-12 15:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-08 1:08 [Qemu-devel] [PATCH] MIPS/GDB: Correct stub handling of CP1 FIR Maciej W. Rozycki
2012-06-12 15:16 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).