From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54204)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SeW5J-0004m1-Va
	for qemu-devel@nongnu.org; Tue, 12 Jun 2012 14:44:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SeW5F-0000RQ-Bn
	for qemu-devel@nongnu.org; Tue, 12 Jun 2012 14:44:57 -0400
Received: from cantor2.suse.de ([195.135.220.15]:45563 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SeW5F-0000QI-5J
	for qemu-devel@nongnu.org; Tue, 12 Jun 2012 14:44:53 -0400
Message-ID: <4FD78E1D.3080400@suse.de>
Date: Tue, 12 Jun 2012 20:44:45 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1339054814-20939-1-git-send-email-pbonzini@redhat.com>
	<1339054814-20939-29-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1339054814-20939-29-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 28/29] configure: ensure directory
 exists when creating symlink
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Anthony Liguori <anthony@codemonkey.ws>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

Am 07.06.2012 09:40, schrieb Paolo Bonzini:
> From: Anthony Liguori <aliguori@us.ibm.com>
>=20
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
>  configure |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/configure b/configure
> index cd5e8b3..cbcbcb1 100755
> --- a/configure
> +++ b/configure
[...]
>  # use included Linux headers
>  if test "$linux" =3D "yes" ; then
> -  mkdir -p linux-headers
>    case "$cpu" in
>    i386|x86_64)
>      symlink "$source_path/linux-headers/asm-x86" linux-headers/asm

This change broke the out-of-tree build on Linux platforms where no
headers are being symlinked, such as Linux/arm:

Makefile.target adds -I../linux-headers irrespective of the
architecture, leading to a file or directory not found error.

If no one beats me to it, I'll send a patch reverting this line tomorrow.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg