From: "Andreas Färber" <afaerber@suse.de>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 3/3] qmp: do not include monitor.h from qapi-types-core.h
Date: Wed, 13 Jun 2012 01:06:45 +0200 [thread overview]
Message-ID: <4FD7CB85.1060405@suse.de> (raw)
In-Reply-To: <4FD03443.9000805@redhat.com>
Am 07.06.2012 06:55, schrieb Anthony Liguori:
> On 06/07/2012 10:02 AM, Paolo Bonzini wrote:
>> The comment is stale, monitor.h is not needed anymore (only qerror.h
>> is, because it contains the schema for errors).
>>
>> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
>> ---
>> qapi/qapi-types-core.h | 4 +---
>> 1 files changed, 1 insertions(+), 3 deletions(-)
>>
>> diff --git a/qapi/qapi-types-core.h b/qapi/qapi-types-core.h
>> index 27e6be0..f781fc3 100644
>> --- a/qapi/qapi-types-core.h
>> +++ b/qapi/qapi-types-core.h
>> @@ -16,8 +16,6 @@
>>
>> #include "qemu-common.h"
>> #include "error.h"
>> -
>> -/* FIXME this is temporary until we remove middle mode */
>> -#include "monitor.h"
>> +#include "qerror.h"
>
> Middle mode generates signatures that contain a 'Monitor *'.
> qmp-commands.h includes qmp-types which only includes qmp-types-core.h
>
> Without having a #include "monitor.h" here, qmp-commands.h is relying on
> something else including monitor.h before including qmp-commands.h
[snip]
Similar situation with some block types - they're being used in one of
these core QAPI files but my CPU-as-a-device branch no longer compiles
since somehow the appropriate block header is no longer being included.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-06-12 23:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 2:02 [Qemu-devel] [PATCH v2 0/3] Clean up includes of monitor.h Paolo Bonzini
2012-06-07 2:02 ` [Qemu-devel] [PATCH v2 1/3] kvm: add missing include files Paolo Bonzini
2012-06-07 2:02 ` [Qemu-devel] [PATCH v2 2/3] qmp: include monitor.h when needed Paolo Bonzini
2012-06-07 2:02 ` [Qemu-devel] [PATCH v2 3/3] qmp: do not include monitor.h from qapi-types-core.h Paolo Bonzini
2012-06-07 4:55 ` Anthony Liguori
2012-06-07 5:35 ` Paolo Bonzini
2012-06-12 23:06 ` Andreas Färber [this message]
2012-06-12 18:57 ` [Qemu-devel] [PATCH v2 0/3] Clean up includes of monitor.h Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD7CB85.1060405@suse.de \
--to=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).