From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Crosthwaite <peter.crosthwaite@petalogix.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Anthony Liguori" <aliguori@us.ibm.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Andreas Färber" <afaerber@suse.de>,
"John Williams" <john.williams@petalogix.com>
Subject: Re: [Qemu-devel] Prop-ptr and Xilinx.
Date: Wed, 13 Jun 2012 08:38:26 +0200 [thread overview]
Message-ID: <4FD83562.4060004@redhat.com> (raw)
In-Reply-To: <CAEgOgz5u5kr7GD6PUY0EsmGuQLkLyQHSnafoobHvaU5Hbyr6Eg@mail.gmail.com>
Il 13/06/2012 08:21, Peter Crosthwaite ha scritto:
>
> Im testing your revisions the the xilinx ip around getting rid of the
> pointer props (your prop-ptr branch on your github).
>
> First up theres a typo in the machine model stuff, heres the fix:
>
> diff --git a/hw/petalogix_ml605_mmu.c b/hw/petalogix_ml605_mmu.c
> index 37866f4..e718183 100644
> --- a/hw/petalogix_ml605_mmu.c
> +++ b/hw/petalogix_ml605_mmu.c
> @@ -126,7 +126,7 @@ petalogix_ml605_init(ram_addr_t ram_size,
> xilinx_timer_create(TIMER_BASEADDR, irq[2], 2, 100 * 1000000);
>
> /* axi ethernet and dma initialization. */
> - DeviceState *dma = qdev_create(NULL, "xilinx-axidma");
> + DeviceState *dma = qdev_create(NULL, "xilinx,axidma");
> DeviceState *eth0;
>
> eth0 = xilinx_axiethernet_create(&nd_table[0], XILINX_AXIDMA_PEER(dma),
>
> I corrected this and ran it but SIGABRT'ed on some assertion in the
> qom framework:
It's quite possible that interfaces are borked, since we have no unit
tests and no user. :/
Paolo
next prev parent reply other threads:[~2012-06-13 6:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 6:21 [Qemu-devel] Prop-ptr and Xilinx Peter Crosthwaite
2012-06-13 6:38 ` Paolo Bonzini [this message]
2012-06-13 8:43 ` Peter Crosthwaite
2012-06-13 9:00 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD83562.4060004@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=edgar.iglesias@gmail.com \
--cc=john.williams@petalogix.com \
--cc=peter.crosthwaite@petalogix.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).