From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54596)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SehDx-0002ek-L2
	for qemu-devel@nongnu.org; Wed, 13 Jun 2012 02:38:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SehDv-0002vu-WC
	for qemu-devel@nongnu.org; Wed, 13 Jun 2012 02:38:37 -0400
Received: from mail-pz0-f47.google.com ([209.85.210.47]:33354)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SehDv-0002vl-NM
	for qemu-devel@nongnu.org; Wed, 13 Jun 2012 02:38:35 -0400
Received: by dalh21 with SMTP id h21so590037dal.34
	for <qemu-devel@nongnu.org>; Tue, 12 Jun 2012 23:38:33 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4FD83562.4060004@redhat.com>
Date: Wed, 13 Jun 2012 08:38:26 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <CAEgOgz5u5kr7GD6PUY0EsmGuQLkLyQHSnafoobHvaU5Hbyr6Eg@mail.gmail.com>
In-Reply-To: <CAEgOgz5u5kr7GD6PUY0EsmGuQLkLyQHSnafoobHvaU5Hbyr6Eg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Prop-ptr and Xilinx.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@petalogix.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, John Williams <john.williams@petalogix.com>

Il 13/06/2012 08:21, Peter Crosthwaite ha scritto:
> 
> Im testing your revisions the the xilinx ip around getting rid of the
> pointer props (your prop-ptr branch on your github).
> 
> First up theres a typo in the machine model stuff, heres the fix:
> 
> diff --git a/hw/petalogix_ml605_mmu.c b/hw/petalogix_ml605_mmu.c
> index 37866f4..e718183 100644
> --- a/hw/petalogix_ml605_mmu.c
> +++ b/hw/petalogix_ml605_mmu.c
> @@ -126,7 +126,7 @@ petalogix_ml605_init(ram_addr_t ram_size,
>      xilinx_timer_create(TIMER_BASEADDR, irq[2], 2, 100 * 1000000);
> 
>      /* axi ethernet and dma initialization. */
> -    DeviceState *dma = qdev_create(NULL, "xilinx-axidma");
> +    DeviceState *dma = qdev_create(NULL, "xilinx,axidma");
>      DeviceState *eth0;
> 
>      eth0 = xilinx_axiethernet_create(&nd_table[0], XILINX_AXIDMA_PEER(dma),
> 
> I corrected this and ran it but SIGABRT'ed on some assertion in the
> qom framework:

It's quite possible that interfaces are borked, since we have no unit
tests and no user. :/

Paolo