From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SelDu-0006SV-K5 for qemu-devel@nongnu.org; Wed, 13 Jun 2012 06:54:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SelDp-00019t-Ve for qemu-devel@nongnu.org; Wed, 13 Jun 2012 06:54:50 -0400 Received: from mail-pz0-f47.google.com ([209.85.210.47]:41673) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SelDp-00019V-Mt for qemu-devel@nongnu.org; Wed, 13 Jun 2012 06:54:45 -0400 Received: by dalh21 with SMTP id h21so940153dal.34 for ; Wed, 13 Jun 2012 03:54:43 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4FD8716C.3030503@redhat.com> Date: Wed, 13 Jun 2012 12:54:36 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1339575768-2557-1-git-send-email-lersek@redhat.com> In-Reply-To: <1339575768-2557-1-git-send-email-lersek@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 00/17] introduce OptsVisitor, rebase -net/-netdev parsing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: qemu-devel@nongnu.org Il 13/06/2012 10:22, Laszlo Ersek ha scritto: > Inspired by [1], the first half of this series attempts to implement a new > visitor that should clean up defining and processing command line options. > For a more detailed description, please see "[PATCH 05/17] qapi: introduce > OptsVisitor". > > The second half converts -net/-netdev parsing to the new visitor. > > v1->v2: > - Insert a small patch between v1 01/16 and v1 02/16 in order to generate > C types for fixed-width integers. > - Tighten / clean up integer types in Netdev options and in OptsVisitor. > - NetLegacy::name is optional. > - Changes are marked below individually and described separately. > - (Rebase to current master.) Looks good, thanks! Paolo