From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Semzx-0003OO-VV for qemu-devel@nongnu.org; Wed, 13 Jun 2012 08:48:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Semzt-00067C-0O for qemu-devel@nongnu.org; Wed, 13 Jun 2012 08:48:33 -0400 Received: from goliath.siemens.de ([192.35.17.28]:18507) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Semzs-00066x-ND for qemu-devel@nongnu.org; Wed, 13 Jun 2012 08:48:28 -0400 Message-ID: <4FD88C0D.10304@siemens.com> Date: Wed, 13 Jun 2012 14:48:13 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1339513523-1699-1-git-send-email-anthony.perard@citrix.com> <1339513523-1699-6-git-send-email-anthony.perard@citrix.com> <20120612151557.GA10691@redhat.com> <4FD8764B.9060003@siemens.com> <4FD880D3.8090203@siemens.com> <4FD88A33.1080304@citrix.com> In-Reply-To: <4FD88A33.1080304@citrix.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony PERARD Cc: Anthony Liguori , "Michael S. Tsirkin" , Xen Devel , QEMU-devel , Stefano Stabellini On 2012-06-13 14:40, Anthony PERARD wrote: > On 13/06/12 13:00, Jan Kiszka wrote: >> On 2012-06-13 13:22, Stefano Stabellini wrote: >>> On Wed, 13 Jun 2012, Jan Kiszka wrote: >>>> On 2012-06-12 17:15, Michael S. Tsirkin wrote: >>>>> On Tue, Jun 12, 2012 at 04:05:19PM +0100, Anthony PERARD wrote: >>>>>> This reverts commit 94a09e2c846374a96719cda2b4e1312d8c4b08a7. >>>>>> >>>>>> This function is used by a later patch to parse the BDF of the device to >>>>>> passthrough. >>>>>> >>>>>> Signed-off-by: Anthony PERARD >>>>> >>>>> You probably want to parse the host address? You don't want to copy the >>>>> bugs in pci_parse_devaddr - write your own that has sane semantics >>>>> for host. E.g. you need to support ARI etc. >>>> >>>> We should really consolidate over one parser for Xen, KVM device >>>> assignment and VFIO. It looks like they all have very similar requirements. >>>> >>>> For those how didn't follow the discussion, see patches 10-13 in >>>> http://thread.gmane.org/gmane.comp.emulators.qemu/153728. >>> >>> I agree, actually it looks like patch 10 and 11 would be enough. >>> >>> Maybe you could extract them and send them out separately? >> >> They are still under discussion and waiting for some QOM refactorings to >> be merged. >> >> Will you be able to use an address parser via some device property? > > Yes. Actually, the address is already a device property. > Great. Then we should try to come up with a common pci-host-devaddr property everyone can use. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux