From: Anthony Liguori <anthony@codemonkey.ws>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com,
qemu-devel@nongnu.org,
"Peter A. G. Crosthwaite" <peter.crosthwaite@petalogix.com>,
paul@codesourcery.com, edgar.iglesias@gmail.com,
"Andreas Färber" <afaerber@suse.de>,
john.williams@petalogix.com, avi@redhat.com
Subject: Re: [Qemu-devel] [RFC v0 5/8] object: make interfaces concrete
Date: Wed, 13 Jun 2012 08:50:53 -0500 [thread overview]
Message-ID: <4FD89ABD.4090201@codemonkey.ws> (raw)
In-Reply-To: <4FD897EB.7040601@redhat.com>
On 06/13/2012 08:38 AM, Paolo Bonzini wrote:
> Il 13/06/2012 15:36, Anthony Liguori ha scritto:
>>>>
>>>
>>> Concrete doesn't mean "instantiatable by the user". It means
>>> "instantiatable period".
>>
>> Interfaces are not supposed to be instantiatable by anyone. The fact
>> that object_new() is used to create the interface is an internal
>> implementation detail.
>
> Whose side effect is that interfaces need to be concrete.
>
>> Interfaces are stateless and by definition, never have an implementation
>> on their own. So object_new() of an interface type directly results in
>> a useless object.
>
> Yes, and that's why you needn't really care about what the user does.
> Garbage in, garbage out...
Quick chat on IRC and I think we both agree that we need to promote the notion
of Interface to a first class concept in QOM.
I'll send out a patch later today (that's actually tested..).
Regards,
Anthony Liguori
>
> Paolo
>
next prev parent reply other threads:[~2012-06-13 13:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 9:38 [Qemu-devel] [RFC v0 0/8] QOMify AXI stream for Xilinx AXI ethernet/DMA Peter A. G. Crosthwaite
2012-06-13 9:38 ` [Qemu-devel] [RFC v0 1/8] qom: revamp interfaces Peter A. G. Crosthwaite
2012-06-13 9:38 ` [Qemu-devel] [RFC v0 2/8] xilinx: remove PROP_PTR properties Peter A. G. Crosthwaite
2012-06-13 9:38 ` [Qemu-devel] [RFC v0 3/8] xilinx_axidma: Added missing TypeInfo Peter A. G. Crosthwaite
2012-06-13 10:05 ` Paolo Bonzini
2012-06-13 9:38 ` [Qemu-devel] [RFC v0 4/8] object: create default canonical paths for orphans Peter A. G. Crosthwaite
2012-06-13 10:08 ` Paolo Bonzini
2012-06-13 9:38 ` [Qemu-devel] [RFC v0 5/8] object: make interfaces concrete Peter A. G. Crosthwaite
2012-06-13 10:03 ` Paolo Bonzini
2012-06-13 10:28 ` Andreas Färber
2012-06-13 10:42 ` Paolo Bonzini
2012-06-13 12:59 ` Andreas Färber
2012-06-13 13:02 ` Paolo Bonzini
2012-06-13 13:30 ` Anthony Liguori
2012-06-13 13:33 ` Paolo Bonzini
2012-06-13 13:36 ` Anthony Liguori
2012-06-13 13:38 ` Paolo Bonzini
2012-06-13 13:50 ` Anthony Liguori [this message]
2012-06-13 20:22 ` Edgar E. Iglesias
2012-06-13 9:38 ` [Qemu-devel] [RFC v0 6/8] xilinx dont cast to interface types with links Peter A. G. Crosthwaite
2012-06-13 10:41 ` Paolo Bonzini
2012-06-13 10:55 ` Avi Kivity
2012-06-13 10:59 ` Paolo Bonzini
2012-06-13 11:02 ` Avi Kivity
2012-06-13 11:05 ` Paolo Bonzini
2012-06-13 11:08 ` Avi Kivity
2012-06-13 13:55 ` Anthony Liguori
2012-06-13 9:38 ` [Qemu-devel] [RFC v0 7/8] petalogix_ml605_mmu: fixed qdev create for dma Peter A. G. Crosthwaite
2012-06-13 9:38 ` [Qemu-devel] [RFC v0 8/8] axidma: renamed interconnect to axi-stream Peter A. G. Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD89ABD.4090201@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=john.williams@petalogix.com \
--cc=paul@codesourcery.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@petalogix.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).