From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeuOH-00018z-56 for qemu-devel@nongnu.org; Wed, 13 Jun 2012 16:42:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SeuOD-0003yc-UO for qemu-devel@nongnu.org; Wed, 13 Jun 2012 16:42:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeuOD-0003vo-La for qemu-devel@nongnu.org; Wed, 13 Jun 2012 16:42:05 -0400 Message-ID: <4FD8FAF6.5050302@redhat.com> Date: Wed, 13 Jun 2012 14:41:26 -0600 From: Eric Blake MIME-Version: 1.0 References: <1339170179-2554-1-git-send-email-coreyb@linux.vnet.ibm.com> <1339170179-2554-2-git-send-email-coreyb@linux.vnet.ibm.com> <20120613164258.6213776a@doriath.home> <4FD8F55A.2030804@linux.vnet.ibm.com> In-Reply-To: <4FD8F55A.2030804@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig7D59FF58C2CA691E5CF48DB1" Subject: Re: [Qemu-devel] [PATCH v2 1/4] qapi: Convert getfd and closefd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Bryant Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, libvir-list@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig7D59FF58C2CA691E5CF48DB1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 06/13/2012 02:17 PM, Corey Bryant wrote: >=20 >=20 > On 06/13/2012 03:42 PM, Luiz Capitulino wrote: >> On Fri, 8 Jun 2012 11:42:56 -0400 >> Corey Bryant wrote: >> >>> v2: >>> - Convert getfd and closefd to QAPI (lcapitulino@redhat.com) >>> - Remove changes that returned fd from getfd (lcapitulino@redhat.co= m) >>> - Wrap hmp_* functions around qmp_* functions (kwolf@redhat.com) >>> - Move hmp_* functions to hmp.c (lcapitulino@redhat.com) >>> - Drop .user_print lines (lcapitulino@redhat.com) >>> - Use 'cmd' instead of 'cmd_new' for HMP (lcapitulino@redhat.com) >>> - Change QMP command existance back to 0.14 (lcapitulino@redhat.com= ) >> >> Btw, having the changelog like this is not nice because it becomes par= t >> of the history. It's better to move it after the '---' line, so that >> git ignores it. >> >=20 > I see your point and I can do this in v3. But can I add text after the= > '---' line in the commit message via 'git commit' or do I have to > manually edit the patches? I also like tracking my notes to self/reviewers in the commit message as I do a rebase. 'git send-email' automatically adds --- at the end of your commit message, so I personally end up using 'git send-email --annotate' and manually move the --- line to occur before my separation point. I think you can also stick --- in the middle of your commit message at which point 'git am' will truncate from the first instance when applying your email, without you having to edit things when mailing, although I haven't tried it myself (at any rate, I have seen patches from others with double --- lines, and assume that the doubled line is a result of the literal --- line in their commit message). Supposedly, it is also possible to use 'git notes' coupled with notes.rewrite* options in your .gitconfig to track your notes over a rebase, as well as an undocumented option to 'git send-email' to have your notes automatically included after a lone --- line, but that are of git is woefully under-documented and probably has issues that need fixing before turning it into a daily workflow. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig7D59FF58C2CA691E5CF48DB1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP2Pr2AAoJEKeha0olJ0Nq+FUH/18DVqXcSQDbLCzMTOUKzpYT DCPRzFrccVcjkXhw2LN69ZcBm+fdCp5HgdnCFtDbV3vIGeBCiZHBXvUpu9pIZICT W0b71W8LpCZq3vyEpnIUFE+M5GloQQtSUTU+gk+fdWusj8m3cIYS9W0Wq9C84COv fWMYeocVwEwCG3IDGQd1gc2YArZLxR9z3I9M54m3VuLklK1XKaottE9PSmmyYHqN 5mhsibsu8kG/CYfokMRqjXhIHF/T5lQDbGzgTUvsRKdDQjVp5l/sjsj7dPOivsp7 4FrqEdDFS6FUqpUg5IIzgEZp+04MJpnyfR7fHTl9+qvoKaatiUs+0DY+HFugRC0= =df8Q -----END PGP SIGNATURE----- --------------enig7D59FF58C2CA691E5CF48DB1--