From: Amos Kong <akong@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16
Date: Thu, 14 Jun 2012 18:20:54 +0800 [thread overview]
Message-ID: <4FD9BB06.3000509@redhat.com> (raw)
In-Reply-To: <20120611142546.66871522@doriath.home>
On 12/06/12 01:25, Luiz Capitulino wrote:
>>
Hi Luiz, Anthony
>> BTW, why is there a 16 keycode limit?
'Sendkey' command was added by this commit
a3a91a355bc6107b7d06d722fb97d2b80065ee0b
Limitation of keycodes number (16) was also introduced here,
and I didn't find the root reason.
>>
> That's a good point. This comes form the array used by the original
> implementation to store the keycodes.
>
> Amos, is it still needed now that we're using qapi lists?
I try to drop this limitation from monitor.c [1], then execute
(qemu) sendkey 1-2-3-4-5-6-7-8-9-0-1-2-3-4-5-6-7-8-9-0
kbd_put_keycode() are called for all (20) keycodes,
but only '123456789012345' can be sent to guest.
It seems we need to notice user when inputted keys are more than 16.
[1]
https://github.com/kongove/QEMU/commit/a198cdcce3ce4c1632221ac7f1e7c4e8efcd9c82
--
Amos.
next prev parent reply other threads:[~2012-06-14 10:21 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 22:54 [Qemu-devel] [PATCH v2 0/6] convert sendkey to qapi Amos Kong
2012-06-01 22:54 ` [Qemu-devel] [PATCH v2 1/6] qerror: add QERR_OVERFLOW Amos Kong
2012-06-04 5:27 ` Anthony Liguori
2012-06-05 14:29 ` [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16 Amos Kong
[not found] ` <4FD0326F.3010806@redhat.com>
[not found] ` <20120611140642.06be2ee8@doriath.home>
[not found] ` <4FD62827.4060900@us.ibm.com>
[not found] ` <20120611142546.66871522@doriath.home>
2012-06-14 10:20 ` Amos Kong [this message]
2012-06-15 7:46 ` Amos Kong
2012-06-15 7:57 ` Gerd Hoffmann
2012-06-15 13:35 ` Luiz Capitulino
2012-06-18 15:30 ` Amos Kong
2012-06-19 9:52 ` Amos Kong
2012-06-01 22:54 ` [Qemu-devel] [PATCH v2 2/6] fix doc of using raw values with sendkey Amos Kong
2012-06-06 18:16 ` Luiz Capitulino
2012-06-01 22:54 ` [Qemu-devel] [PATCH v2 3/6] rename keyname '<' to 'less' Amos Kong
2012-06-06 18:22 ` Luiz Capitulino
2012-06-06 23:12 ` Amos Kong
2012-06-01 22:54 ` [Qemu-devel] [PATCH v2 4/6] hmp: rename arguments Amos Kong
2012-06-01 22:54 ` [Qemu-devel] [PATCH v2 5/6] qapi: generate list struct and visit_list for enum Amos Kong
2012-06-05 15:01 ` Amos Kong
2012-06-06 18:40 ` Luiz Capitulino
2012-06-07 0:26 ` Michael Roth
2012-06-07 2:52 ` Amos Kong
2012-06-11 17:00 ` Luiz Capitulino
2012-06-07 0:15 ` Michael Roth
2012-06-07 3:33 ` Amos Kong
2012-06-01 22:54 ` [Qemu-devel] [PATCH v2 6/6] qapi: convert sendkey Amos Kong
2012-06-04 17:09 ` Eric Blake
2012-06-05 14:55 ` Amos Kong
2012-06-05 15:05 ` Eric Blake
2012-06-06 7:13 ` Amos Kong
2012-06-06 11:58 ` Eric Blake
2012-06-07 4:51 ` Anthony Liguori
2012-06-07 13:08 ` Eric Blake
2012-06-01 23:03 ` [Qemu-devel] [PATCH v2 0/6] convert sendkey to qapi Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD9BB06.3000509@redhat.com \
--to=akong@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).