From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40503) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf7sc-0002lj-21 for qemu-devel@nongnu.org; Thu, 14 Jun 2012 07:06:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sf7sV-0005zi-St for qemu-devel@nongnu.org; Thu, 14 Jun 2012 07:06:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7696) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf7sV-0005zS-Ks for qemu-devel@nongnu.org; Thu, 14 Jun 2012 07:06:15 -0400 Message-ID: <4FD9C5A2.5090209@redhat.com> Date: Thu, 14 Jun 2012 13:06:10 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1339670543-6394-1-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1339670543-6394-1-git-send-email-stefanha@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qcow2: fix autoclear image header update List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org Am 14.06.2012 12:42, schrieb Stefan Hajnoczi: > The autoclear feature bits can be used for qcow2 file format features > that are safe to "drop" by old programs that do not understand the > feature. Upon opening the image file unknown autoclear feature bits are > cleared and the image file header is rewritten, but this was happening > too early in the code when critical header fields were not yet loaded. > > Process autoclear feature bits after all necessary header information > has been loaded. > > Signed-off-by: Stefan Hajnoczi Ouch... You don't have a qemu-iotests case to offer for the feature bit handling, by any chance? Kevin