From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52945) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf90D-0000jM-Av for qemu-devel@nongnu.org; Thu, 14 Jun 2012 08:18:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sf906-00081t-UQ for qemu-devel@nongnu.org; Thu, 14 Jun 2012 08:18:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62605) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf906-00081n-M4 for qemu-devel@nongnu.org; Thu, 14 Jun 2012 08:18:10 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5ECI8aJ005079 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 14 Jun 2012 08:18:09 -0400 Message-ID: <4FD9D67F.5080505@redhat.com> Date: Thu, 14 Jun 2012 06:18:07 -0600 From: Eric Blake MIME-Version: 1.0 References: <806c66b2f071f03bec0b7d45a71512e394386885.1339617170.git.phrdina@redhat.com> In-Reply-To: <806c66b2f071f03bec0b7d45a71512e394386885.1339617170.git.phrdina@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig0858D571A80C0D5C824D7241" Subject: Re: [Qemu-devel] [PATCH v2] qapi: converted commit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Hrdina Cc: kwolf@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig0858D571A80C0D5C824D7241 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/14/2012 01:35 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > +++ b/qapi-schema.json > @@ -1169,6 +1169,21 @@ > { 'command': 'block_resize', 'data': { 'device': 'str', 'size': 'int' = }} > =20 > ## > +# @commit > +# > +# Commit changes to the disk images (if -snapshot is used) or backing = files. > +# > +# @device: the name of the device or the "all" to commit all devices > +# > +# Returns: nothing on success > +# If @device is not a valid block device, DeviceNotFound > +# If a long-running operation is using the device, DeviceInUs= e > +# > +# Since: 1.2 > +## > +{ 'command': 'commit', 'data': { 'device': 'str' }} Should we use this as an opportunity to make the command more powerful? For example, integrating this with the 'transaction' command or a block job queried by 'query-block-jobs' to track its progress would be useful. Also, suppose I have A <- B <- C. Does 'commit' only do one layer (C into B), or all layers (B and C into A)? That argues that we need an optional parameter that says how deep to commit (committing C into B only to repeat and commit B into A is more time-consuming than directly committing both B and C into A to start with). When a commit is complete, which file is backing the device - is it still C (which continues to diverge, but now from the point of the commit) or does qemu pivot things to have the device now backed by B (and C can be discarded, particularly true if changes are now going into B which invalidate C). --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig0858D571A80C0D5C824D7241 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP2dZ/AAoJEKeha0olJ0NqFoYH+wWCF9ZMJDAlBlC2IDmsQHOT 41D9FOuerYV6X6txQ92/WTgUpropflxV1wAmjtIKwUz032lT2TjKniSupnoQyYVb u/y97xddh9oPO4X/i70OKFL88/SaW8CIH4W33p+YyesgUFgtgSqmFodhPFbAzRLG AxgSYzwN2WQKS+jniqOzsIxWA6cThDndB8vXCeEYUni3Vf0o+FtGhVJ/D5A4iUFz IdLr4OK+S+n/7/w8Xl5ULc+9U6FZkMkwfMX41xHlpze6ZfPBOlqxguKW0JDj5NED Zpq6CEFUJhhELrqhFK/JInJ14SYniWoVrgUXSlHU/8TwVVnKyCjT7oRnKZSwaoE= =2Y0n -----END PGP SIGNATURE----- --------------enig0858D571A80C0D5C824D7241--