From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45464)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SfAjB-0003QO-82
	for qemu-devel@nongnu.org; Thu, 14 Jun 2012 10:08:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SfAj4-0005mk-U5
	for qemu-devel@nongnu.org; Thu, 14 Jun 2012 10:08:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55078)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SfAj4-0005mZ-Lc
	for qemu-devel@nongnu.org; Thu, 14 Jun 2012 10:08:42 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5EE8fXM027922
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 14 Jun 2012 10:08:41 -0400
Message-ID: <4FD9F067.1020405@redhat.com>
Date: Thu, 14 Jun 2012 16:08:39 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <cover.1339593749.git.phrdina@redhat.com>
In-Reply-To: <cover.1339593749.git.phrdina@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 0/4] fdc: fix/rewrite seek,
 media_changed and interrupt handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Hrdina <phrdina@redhat.com>
Cc: qemu-devel@nongnu.org

Am 13.06.2012 15:43, schrieb Pavel Hrdina:
> The fd_seek will return 'track is invalid' if there is no media in drive.
> 
> Implied seek should have the same behavior as normal seek. We will use the fd_seek
> function instead of a direct modification of head, track and sector values.
> The result value is used only while read/write commands were issued.
> 
> Fixed sense interrupt status command.
> 
> v5:
>     - correction of misspelled words
> 
> v4:
>     - fixed coding style
>     - better bit clearing in 'fdctrl_handle_sense_interrupt_status'
> 
> v3:
>     - added fdc-test
>     - rewrited seek and media_changed handling
>     - fixed interrupt status handling
> 
> v2:
>     - better way to detect media missing
> 
> Pavel Hrdina (4):
>   fdc: fix implied seek while there is no media in drive
>   fdc-test: introduced qtest read_without_media
>   fdc: rewrite seek and DSKCHG bit handling
>   fdc: fix interrupt handling
> 
>  hw/fdc.c         |  106 ++++++++++++++++++++++++++++++------------------------
>  tests/fdc-test.c |   66 +++++++++++++++++++++++++++++++++
>  2 files changed, 125 insertions(+), 47 deletions(-)
> 

Thanks, I applied patches 1 and 2. For the rest I'm waiting for a v6
that includes test cases.

Kevin