From: "Andreas Färber" <afaerber@suse.de>
To: "\"陳韋任 (Wei-Ren Chen)\"" <chenwj@iis.sinica.edu.tw>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Does kvm_fd mean KVM or VCPU fd?
Date: Thu, 14 Jun 2012 16:49:37 +0200 [thread overview]
Message-ID: <4FD9FA01.6000907@suse.de> (raw)
In-Reply-To: <20120614101646.GA18229@cs.nctu.edu.tw>
Am 14.06.2012 12:16, schrieb 陳韋任 (Wei-Ren Chen):
>>> I think KVM_CREATE_VCPU should return VCPU fd, right? AFAIK, in KVM
>>> world, kvm_fd usually means the fd we get after opening "/dev/kvm".
>>> Just want to make sure I understand the code correcly. Thanks.
>>
>> This is the kvm_fd inside struct CPUState, so it's per-CPU.
>
> Okay, then it's VCPU fd. Don't know rename it or add a comment to indicate
> it's a VCPU fd is a good idea. ;)
Not a good idea, those fields need to move from CPU*State to CPUState.
We can rename them then if someone has a good suggestion.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2012-06-14 14:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 8:24 [Qemu-devel] Does kvm_fd mean KVM or VCPU fd? 陳韋任 (Wei-Ren Chen)
2012-06-14 9:15 ` Paolo Bonzini
2012-06-14 10:16 ` 陳韋任 (Wei-Ren Chen)
2012-06-14 14:49 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD9FA01.6000907@suse.de \
--to=afaerber@suse.de \
--cc=chenwj@iis.sinica.edu.tw \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).