From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfBMs-0007ce-M2 for qemu-devel@nongnu.org; Thu, 14 Jun 2012 10:49:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SfBMk-0001BV-9t for qemu-devel@nongnu.org; Thu, 14 Jun 2012 10:49:50 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45567 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfBMk-0001BC-3I for qemu-devel@nongnu.org; Thu, 14 Jun 2012 10:49:42 -0400 Message-ID: <4FD9FA01.6000907@suse.de> Date: Thu, 14 Jun 2012 16:49:37 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <20120614082444.GA1692@cs.nctu.edu.tw> <4FD9AB9A.4080401@redhat.com> <20120614101646.GA18229@cs.nctu.edu.tw> In-Reply-To: <20120614101646.GA18229@cs.nctu.edu.tw> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] Does kvm_fd mean KVM or VCPU fd? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?IumZs+mfi+S7uyAoV2VpLVJlbiBDaGVuKSI=?= Cc: Paolo Bonzini , qemu-devel@nongnu.org Am 14.06.2012 12:16, schrieb =E9=99=B3=E9=9F=8B=E4=BB=BB (Wei-Ren Chen): >>> I think KVM_CREATE_VCPU should return VCPU fd, right? AFAIK, in KVM >>> world, kvm_fd usually means the fd we get after opening "/dev/kvm". >>> Just want to make sure I understand the code correcly. Thanks. >> >> This is the kvm_fd inside struct CPUState, so it's per-CPU. >=20 > Okay, then it's VCPU fd. Don't know rename it or add a comment to ind= icate > it's a VCPU fd is a good idea. ;) Not a good idea, those fields need to move from CPU*State to CPUState. We can rename them then if someone has a good suggestion. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg