qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH buildfix] configure: Assure existence of linux-headers/ build directory
Date: Thu, 14 Jun 2012 17:56:47 +0200	[thread overview]
Message-ID: <4FDA09BF.30502@suse.de> (raw)
In-Reply-To: <1339686873-5528-1-git-send-email-afaerber@suse.de>

Am 14.06.2012 17:14, schrieb Andreas Färber:
> Commit ec5b06d (configure: ensure directory exists when creating symlinks)
> moved the creation of directories into the symlink() function but forgot
> the case where no symlink is created.
> 
> This leads to build errors on arm Linux due to -I../linux-headers.
> 
> Unbreak the build on arm Linux by reverting part of that commit.

Er, "Unbreak the build by..." would suffice, no need to double-duplicate. ;)

/-F

> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  configure |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configure b/configure
> index c2366ee..ba8cc7c 100755
> --- a/configure
> +++ b/configure
> @@ -3462,6 +3462,7 @@ done
>  
>  # use included Linux headers
>  if test "$linux" = "yes" ; then
> +  mkdir -p linux-headers
>    case "$cpu" in
>    i386|x86_64)
>      symlink "$source_path/linux-headers/asm-x86" linux-headers/asm


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2012-06-14 15:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-14 15:14 [Qemu-devel] [PATCH buildfix] configure: Assure existence of linux-headers/ build directory Andreas Färber
2012-06-14 15:56 ` Andreas Färber [this message]
2012-06-19 15:18 ` Peter Maydell
2012-06-19 15:24   ` Andreas Färber
2012-06-20 10:42     ` Peter Maydell
2012-06-20 16:30 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FDA09BF.30502@suse.de \
    --to=afaerber@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).