From: Harsh Bora <harsh@linux.vnet.ibm.com>
To: Harsh Bora <harsh@linux.vnet.ibm.com>
Cc: stefanha@gmail.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v5 2/3] Simpletrace v2: Support multiple arguments, strings.
Date: Thu, 14 Jun 2012 23:17:05 +0530 [thread overview]
Message-ID: <4FDA2399.8070200@linux.vnet.ibm.com> (raw)
In-Reply-To: <4FD9EC67.5080301@linux.vnet.ibm.com>
[...]
Okay I think, I got it, let me dig a little further ...
>> +void trace_record_finish(TraceBufferRecord *rec)
>> {
>> - trace(event, x1, x2, x3, x4, x5, x6);
>> + uint8_t temp_rec[sizeof(TraceRecord)];
>> + TraceRecord *record = (TraceRecord *) temp_rec;
>> + read_from_buffer(rec->tbuf_idx, temp_rec, sizeof(TraceRecord));
>> + __sync_synchronize(); /* write barrier before marking as valid */
>> + record->event |= TRACE_RECORD_VALID;
>> + write_to_buffer(rec->tbuf_idx, temp_rec, sizeof(TraceRecord));
>> +
>> + if ((trace_idx> writeout_idx)&&
>> + (trace_idx - writeout_idx)> TRACE_BUF_FLUSH_THRESHOLD) {
>> + flush_trace_file(false);
>> + } else if ((writeout_idx> trace_idx)&&
>> + (trace_idx> TRACE_BUF_FLUSH_THRESHOLD)) {
I guess this was the culprit ^ ..
Harsh
next prev parent reply other threads:[~2012-06-14 17:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 13:32 [Qemu-devel] [PATCH v5 0/3] Simpletrace v2: Support multiple args, strings Harsh Prateek Bora
2012-06-14 13:32 ` [Qemu-devel] [PATCH v5 1/3] monitor: remove unused do_info_trace Harsh Prateek Bora
2012-06-14 13:32 ` [Qemu-devel] [PATCH v5 2/3] Simpletrace v2: Support multiple arguments, strings Harsh Prateek Bora
2012-06-14 13:51 ` Harsh Bora
2012-06-14 17:47 ` Harsh Bora [this message]
2012-06-14 13:32 ` [Qemu-devel] [PATCH v5 3/3] Update simpletrace.py for new log format Harsh Prateek Bora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDA2399.8070200@linux.vnet.ibm.com \
--to=harsh@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).