From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfRPs-0005cu-Q1 for qemu-devel@nongnu.org; Fri, 15 Jun 2012 03:58:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SfRPm-0002Fd-Km for qemu-devel@nongnu.org; Fri, 15 Jun 2012 03:58:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfRPm-0002FR-Co for qemu-devel@nongnu.org; Fri, 15 Jun 2012 03:57:54 -0400 Message-ID: <4FDAEAFD.9090406@redhat.com> Date: Fri, 15 Jun 2012 09:57:49 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <433764b9-c58b-4b4e-8a4d-0f6cd84a25e7@zmail13.collab.prod.int.phx2.redhat.com> <4FD0326F.3010806@redhat.com> <20120611140642.06be2ee8@doriath.home> <4FD62827.4060900@us.ibm.com> <20120611142546.66871522@doriath.home> <4FD9BB06.3000509@redhat.com> <4FDAE857.6050106@redhat.com> In-Reply-To: <4FDAE857.6050106@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: Anthony Liguori , qemu-devel@nongnu.org, Luiz Capitulino Hi, >> It seems we need to notice user when inputted keys are more than 16. > > Hi Gerd, > > When I use 'sendkey' command to send key-series to guest, some keyboard > events will be send. There is a limitation (16) that was introduced by this > old commit c8256f9d (without description). Do you know the reason? Probably hardware limitation, ps/2 keyboards can buffer up to 16 keys IIRC. Likewise the usb hid devices can buffer up to 16 events. In that case it is just a qemu implementation detail and not a property of the hardware we are emulating, so it can be changed. Not trivially though as the buffer is part of the migration data, so it is more work that just changing a #define. HTH, Gerd