From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: jcody@redhat.com, qemu-devel@nongnu.org,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] introduce bdrv_swap, implement bdrv_append on top
Date: Fri, 15 Jun 2012 11:38:06 +0200 [thread overview]
Message-ID: <4FDB027E.3030907@redhat.com> (raw)
In-Reply-To: <1339685702-10176-1-git-send-email-pbonzini@redhat.com>
Am 14.06.2012 16:55, schrieb Paolo Bonzini:
> Yet another tiny bit extracted from block mirroring, looks like it
> should be useful for block commit too.
>
> Paolo Bonzini (2):
> block: copy over job and dirty bitmap fields in bdrv_append
> block: introduce bdrv_swap, implement bdrv_append on top of it
>
> block.c | 175 +++++++++++++++++++++++++++++++++++++--------------------------
> block.h | 1 +
> 2 files changed, 103 insertions(+), 73 deletions(-)
>
I was really hoping we could get rid of bdrv_append() rather than extend
it and spread its use...
What exactly do we need this for? I'm sure you have good reasons, but
with such hackish approaches the justification should be explicit.
Kevin
next prev parent reply other threads:[~2012-06-15 9:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 14:55 [Qemu-devel] [PATCH 0/2] introduce bdrv_swap, implement bdrv_append on top Paolo Bonzini
2012-06-14 14:55 ` [Qemu-devel] [PATCH 1/2] block: copy over job and dirty bitmap fields in bdrv_append Paolo Bonzini
2012-06-14 14:55 ` [Qemu-devel] [PATCH 2/2] block: introduce bdrv_swap, implement bdrv_append on top of it Paolo Bonzini
2012-07-04 10:30 ` Kevin Wolf
2012-06-15 9:38 ` Kevin Wolf [this message]
2012-06-15 9:42 ` [Qemu-devel] [PATCH 0/2] introduce bdrv_swap, implement bdrv_append on top Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDB027E.3030907@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=jcody@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).