qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: "Peter A. G. Crosthwaite" <peter.crosthwaite@petalogix.com>,
	edgar.iglesias@gmail.com
Cc: monstr@monstr.eu, qemu-devel@nongnu.org, john.williams@petalogix.com
Subject: Re: [Qemu-devel] [PATCH v2 09/11] xilinx_axienet: changed device name
Date: Fri, 15 Jun 2012 13:29:12 +0200	[thread overview]
Message-ID: <4FDB1C88.8000506@suse.de> (raw)
In-Reply-To: <2fe15430c9332b3de9ba6969ca5303ba45be5b51.1339562634.git.peter.crosthwaite@petalogix.com>

Am 13.06.2012 06:46, schrieb Peter A. G. Crosthwaite:
> Changed device name to xlnx,axi-ethernet. This is the exact name of the
> device in the xilinx EDK development tools.
> 
> Signed-off-by: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>

Commit message doesn't match the change. Which one is right?

/-F

> ---
>  hw/xilinx.h         |    4 ++--
>  hw/xilinx_axienet.c |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/xilinx.h b/hw/xilinx.h
> index 5108cf5..52fce01 100644
> --- a/hw/xilinx.h
> +++ b/hw/xilinx.h
> @@ -54,9 +54,9 @@ xilinx_axiethernet_create(void *dmach,
>                            int txmem, int rxmem)
>  {
>      DeviceState *dev;
> -    qemu_check_nic_model(nd, "xilinx-axienet");
> +    qemu_check_nic_model(nd, "xlnx.axi-ethernet");
>  
> -    dev = qdev_create(NULL, "xilinx,axienet");
> +    dev = qdev_create(NULL, "xlnx.axi-ethernet");
>      qdev_set_nic_properties(dev, nd);
>      qdev_prop_set_uint32(dev, "rxmem", rxmem);
>      qdev_prop_set_uint32(dev, "txmem", txmem);
> diff --git a/hw/xilinx_axienet.c b/hw/xilinx_axienet.c
> index d383aee..2e8d8a5 100644
> --- a/hw/xilinx_axienet.c
> +++ b/hw/xilinx_axienet.c
> @@ -889,7 +889,7 @@ static void xilinx_enet_class_init(ObjectClass *klass, void *data)
>  }
>  
>  static TypeInfo xilinx_enet_info = {
> -    .name          = "xilinx,axienet",
> +    .name          = "xlnx.axi-ethernet",
>      .parent        = TYPE_SYS_BUS_DEVICE,
>      .instance_size = sizeof(struct XilinxAXIEnet),
>      .class_init    = xilinx_enet_class_init,

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2012-06-15 11:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-13  4:46 [Qemu-devel] [PATCH v2 00/11] Xilinx Devs: refactored device and property names Peter A. G. Crosthwaite
2012-06-13  4:46 ` [Qemu-devel] [PATCH v2 01/11] xilinx_uartlite: changed device name Peter A. G. Crosthwaite
2012-06-15 11:32   ` Andreas Färber
2012-06-13  4:46 ` [Qemu-devel] [PATCH v2 02/11] xilinx_timer: added default frequency Peter A. G. Crosthwaite
2012-06-13  4:46 ` [Qemu-devel] [PATCH v2 03/11] xilinx_timer: changed nr_timers to one_timer_only Peter A. G. Crosthwaite
2012-06-13  4:46 ` [Qemu-devel] [PATCH v2 04/11] xilinx_timer: changed device name Peter A. G. Crosthwaite
2012-06-13  4:46 ` [Qemu-devel] [PATCH v2 05/11] xilinx_intc: " Peter A. G. Crosthwaite
2012-06-15 11:31   ` Andreas Färber
2012-06-13  4:46 ` [Qemu-devel] [PATCH v2 06/11] xilinx_ethlite: tweaked naming of ping-pong props Peter A. G. Crosthwaite
2012-06-13  4:46 ` [Qemu-devel] [PATCH v2 07/11] xilinx_ethlite: changed device name Peter A. G. Crosthwaite
2012-06-15 11:30   ` Andreas Färber
2012-06-13  4:46 ` [Qemu-devel] [PATCH v2 08/11] xilinx_axienet: droped the c_ on parameters Peter A. G. Crosthwaite
2012-06-13  4:46 ` [Qemu-devel] [PATCH v2 09/11] xilinx_axienet: changed device name Peter A. G. Crosthwaite
2012-06-15 11:29   ` Andreas Färber [this message]
2012-06-13  4:46 ` [Qemu-devel] [PATCH v2 10/11] xilinx_axidma: (un)reversed irq initialisation Peter A. G. Crosthwaite
2012-06-13  4:46 ` [Qemu-devel] [PATCH v2 11/11] xilinx_axidma: changed device name Peter A. G. Crosthwaite
2012-06-15 11:30   ` Andreas Färber
2012-06-16  1:11     ` Edgar E. Iglesias
2012-06-15 11:14 ` [Qemu-devel] [PATCH v2 00/11] Xilinx Devs: refactored device and property names Edgar E. Iglesias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FDB1C88.8000506@suse.de \
    --to=afaerber@suse.de \
    --cc=edgar.iglesias@gmail.com \
    --cc=john.williams@petalogix.com \
    --cc=monstr@monstr.eu \
    --cc=peter.crosthwaite@petalogix.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).