From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44828)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SfVuy-0007D6-0U
	for qemu-devel@nongnu.org; Fri, 15 Jun 2012 08:46:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SfVuu-0000jF-10
	for qemu-devel@nongnu.org; Fri, 15 Jun 2012 08:46:23 -0400
Received: from cantor2.suse.de ([195.135.220.15]:48478 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SfVut-0000in-O9
	for qemu-devel@nongnu.org; Fri, 15 Jun 2012 08:46:19 -0400
Message-ID: <4FDB2E93.2020708@suse.de>
Date: Fri, 15 Jun 2012 14:46:11 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <cover.1339753406.git.gxt@mprc.pku.edu.cn>
	<da32f0737891ac4d245b36f7b775c9ab0e4a1741.1339753406.git.gxt@mprc.pku.edu.cn>
	<jrf2ol$enq$1@dough.gmane.org>
In-Reply-To: <jrf2ol$enq$1@dough.gmane.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCHv2 01/13] unicore32-softmmu: Add
 unicore32-softmmu build support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Guan Xuetao <gxt@mprc.pku.edu.cn>, qemu-devel@nongnu.org, =?UTF-8?B?6Zmz6Z+L5Lu7?= <chenwj@iis.sinica.edu.tw>

Am 15.06.2012 12:28, schrieb Paolo Bonzini:
> Il 15/06/2012 11:47, Guan Xuetao ha scritto:
>> This patch adds unicore32-softmmu build support, include configure,
>> makefile, arch_init, and all missing functions needed by softmmu.
>> Although all missing functions are empty, unicore32-softmmu could
>> be build successfully.
>>
>> Signed-off-by: Guan Xuetao <gxt@mprc.pku.edu.cn>
>> ---
>>  Makefile.target                       |    2 +
>>  arch_init.c                           |    2 +
>>  arch_init.h                           |    1 +
>>  configure                             |    1 +
>>  default-configs/unicore32-softmmu.mak |    1 +
>>  target-unicore32/helper.c             |   25 +++++++++++----------
>>  target-unicore32/machine.c            |   23 +++++++++++++++++++
>>  target-unicore32/op_helper.c          |   24 +++++++++++++++++++-
>>  target-unicore32/softmmu.c            |   39 ++++++++++++++++++++++++=
+++++++++
>>  9 files changed, 105 insertions(+), 13 deletions(-)
>>  create mode 100644 default-configs/unicore32-softmmu.mak
>>  create mode 100644 target-unicore32/machine.c
>>  create mode 100644 target-unicore32/softmmu.c
>>
>> diff --git a/Makefile.target b/Makefile.target
>> index 1582904..7d3b1fd 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -387,6 +387,8 @@ obj-xtensa-y +=3D core-dc232b.o
>>  obj-xtensa-y +=3D core-dc233c.o
>>  obj-xtensa-y +=3D core-fsf.o
>> =20
>> +obj-unicore32-y +=3D softmmu.o
>> +
>=20
> You need to rebase this and put this line (actually
> obj-$(CONFIG_SOFTMMU) +=3D softmmu.o) in target-unicore32/Makefile.objs=
.

Noticed this, too. I wonder if Xuetao could place the new puv3.c machine
file into hw/unicore32/ now, if he wanted?
The devices now compiled through hw/Makefile.objs should probably remain
in hw/? Or is it acceptable to have "unicore32/puv3.o" in
hw/Makefile.objs with the new build system?

General design question. :)

Andreas

P.S. Please avoid dropping the CCs, the author doesn't seem to be
following qemu-devel too closely and it helps avoid double replies.

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg