From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfXt6-0007A9-Ol for qemu-devel@nongnu.org; Fri, 15 Jun 2012 10:52:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SfXt4-0000iO-US for qemu-devel@nongnu.org; Fri, 15 Jun 2012 10:52:36 -0400 Received: from cantor2.suse.de ([195.135.220.15]:59519 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfXt4-0000hv-L9 for qemu-devel@nongnu.org; Fri, 15 Jun 2012 10:52:34 -0400 Message-ID: <4FDB4C2C.1070305@suse.de> Date: Fri, 15 Jun 2012 16:52:28 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1339206871-4706-1-git-send-email-afaerber@suse.de> <20120615111339.GA7617@edde.se.axis.com> In-Reply-To: <20120615111339.GA7617@edde.se.axis.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/3] xilinx: Speed up the build List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Edgar E. Iglesias" Cc: "Peter A. G. Crosthwaite" , qemu-devel@nongnu.org Am 15.06.2012 13:13, schrieb Edgar E. Iglesias: > On Sat, Jun 09, 2012 at 03:54:28AM +0200, Andreas F=E4rber wrote: >> Hello Edgar and Peter, >> >> With the Makefile refactoring applied now, here's the Makefile improve= ments >> for MicroBlaze I mentioned. >> >> All Xilinx devices that are used for more than one softmmu are compile= d once >> in libhw32. Actually some also in libhw64 due to ppc440 being compiled= into >> ppc64, but we can fix that in a second step via Alex' ppc-next, we're = already >> down from thrice to twice. >> >> The middle patch is extracted from Blue's logging refactoring. >> >> Please test and apply. Your s3adp1800 and virtel_ml507 test images com= plain >> both with and without patches about not finding "eth0". Selftest compl= etes ok >> except for not finding /usr/bin/sha1test on ppc440. >> >> xilinx_ethlite.c uses tswap32(). Have you ever tested this device to w= ork on >> microblazeel? I wonder if we could change the device from DEVICE_NATIV= E_ENDIAN >> to DEVICE_BIG_ENDIAN and in place of tswap32() use a bswap32() conditi= onal on >> HOST_WORDS_BIGENDIAN so that it becomes independent of the target, too= ? >> >> Instead of adding random devices to hw/microblaze/Makefile.objs in new= series, >> they should be added to hw/Makefile.objs with appropriate CONFIG_* opt= ions set >> in default-configs/microblaze[el]-softmmu.mak as demonstrated here, ea= sy to do >> and also ensures that the appropriate poisoning is applied. >=20 > Applied the series, thanks Andreas. Thanks, but didn't you want CONFIG_XILINX renamed? :) Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg