From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:32830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfZoC-0001fM-8s for qemu-devel@nongnu.org; Fri, 15 Jun 2012 12:55:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SfZoA-0005Pu-IS for qemu-devel@nongnu.org; Fri, 15 Jun 2012 12:55:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54550) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfZoA-0005PN-AB for qemu-devel@nongnu.org; Fri, 15 Jun 2012 12:55:38 -0400 Message-ID: <4FDB6905.8050703@redhat.com> Date: Fri, 15 Jun 2012 18:55:33 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1338387301-10074-1-git-send-email-lcapitulino@redhat.com> <1338387301-10074-3-git-send-email-lcapitulino@redhat.com> <4FC74B1A.8080700@redhat.com> <20120531110608.4dc3fe22@doriath.home> <4FC77F6C.8000008@redhat.com> <20120531113127.1c8aa213@doriath.home> <4FC78637.4040605@redhat.com> <20120613144910.598bfe24@doriath.home> <4FDB6869.1000509@us.ibm.com> In-Reply-To: <4FDB6869.1000509@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Adding errno to QMP errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , armbru@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino Il 15/06/2012 18:52, Anthony Liguori ha scritto: > Having an error like: > > { 'error': 'OpenFileFailed', 'file': 'filename', 'mode': 'r/w', > 'os_error': 'enospc' } > > is actually pretty reasonable for something like a memory dump command > where the user specifies a file. > > OTOH, for something complex like live snapshotting which many involve > opening multiple files, it may not be good enough. > > So context is really everything here. I agree, though I think this is the least of the problems in reporting errors from complex commands such as transaction. :) So I guess we can proceed with errno values, yuppy! Paolo