From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sfa8s-0003KB-N4 for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:17:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sfa8q-0005NP-Ry for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:17:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20444) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sfa8q-0005N3-JV for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:17:00 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5FHGwaf023767 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 15 Jun 2012 13:16:58 -0400 Message-ID: <4FDB6E04.9000201@redhat.com> Date: Fri, 15 Jun 2012 11:16:52 -0600 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig155569CCC3636A6C7DB571D4" Subject: Re: [Qemu-devel] [libvirt] [PATCH 2/2] qemu_agent: Wait for events instead of agent response List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michal Privoznik Cc: libvir-list@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig155569CCC3636A6C7DB571D4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 06/15/2012 10:10 AM, Michal Privoznik wrote: > With latest changes to qemu-ga success on some commands is not reported= > anymore, e.g. guest-shutdown or guest-suspend-*. However, errors are > still being reported. Therefore, we need to find different source of > indication if operation was successful. Events. > --- > src/qemu/qemu_agent.c | 49 +++++++++++++++++++++++++++++++++++++++= +++---- > src/qemu/qemu_agent.h | 9 ++++++++ > src/qemu/qemu_process.c | 7 ++++++ > 3 files changed, 60 insertions(+), 5 deletions(-) >=20 > @@ -1238,6 +1257,24 @@ error: > return NULL; > } > =20 > +void qemuAgentNotifyEvent(qemuAgentPtr mon, > + qemuAgentEvent event) > +{ > + VIR_DEBUG("mon=3D%p event=3D%d", mon, event); > + if (mon->await_event =3D=3D event) { > + VIR_DEBUG("Wakening up a tragedian"); s/Wakening/Waking/ ACK. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig155569CCC3636A6C7DB571D4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP224FAAoJEKeha0olJ0Nqv3kH+wZD+WSC2vis/OsST43d7Ob5 1Ub6CglCu224deEUfmiWiaBRD4kwC347yVEBR0LBVhQK2tTW0IzfBSNa3VKg93HZ Umcu5FIzGj62B1ovgut5z/E3ismdKehSu3Xp2xAt8rhN7Q0Bo4vrYQqdcjgFKUJr Nub/r3vPBOBoF/mAyEB1J1zt0RwzlGQMZtaA3XfHzS/lr6mtFgdXmfil3Z+9UY36 BgjPZ0eI1rnWDGibpo2ryEnczunPCw6Q/8qxFxAtdhM8EFp4geCiqTP/S/2Mftxx 5IBvtXKjjw2OXQnsqgiYnIR3f9p+eL2n94j8Cbs8v6T+GPuuI+aKAdgHM4TERzQ= =QpxS -----END PGP SIGNATURE----- --------------enig155569CCC3636A6C7DB571D4--