From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfaOt-0007Jq-NQ for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:33:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SfaOr-0003gX-Ro for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:33:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfaOr-0003fz-JY for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:33:33 -0400 Message-ID: <4FDB71C1.6050807@redhat.com> Date: Fri, 15 Jun 2012 11:32:49 -0600 From: Eric Blake MIME-Version: 1.0 References: <1339772759-31004-1-git-send-email-pbonzini@redhat.com> <1339772759-31004-7-git-send-email-pbonzini@redhat.com> In-Reply-To: <1339772759-31004-7-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigF9F7F222CAE584C7F1BA6FD5" Subject: Re: [Qemu-devel] [RFC PATCH 06/36] qmp: add block-job-pause and block-job-resume List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF9F7F222CAE584C7F1BA6FD5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > Add QMP commands matching the functionality. >=20 > Paused jobs cannot be canceled without first resuming them. This > ensures that I/O errors are never missed by management. However, an > optional force argument can be specified to allow that. >=20 > Signed-off-by: Paolo Bonzini > +++ b/qapi-schema.json > +## > +# @block-job-pause: > +# > +# Pause an active background block operation. > +# > +# This command returns immediately after marking the active background= block > +# operation for pausing. It is an error to call this command if no > +# operation is in progress. > +# > +# The operation will pause as soon as possible. No event is emitted w= hen > +# the operation is actually paused. Cancelling a paused job automatic= ally US (Canceling) vs. UK (Cancelling) > +# resumes it. > +# > +# @device: the device name > +# > +# Returns: Nothing on success > +# If no background operation is active on this device, Device= NotActive > +# > +# Since: 1.1 1.2 > +# @block-job-resume: > +# > +# Resume an active background block operation. > +# > +# This command returns immediately after resuming a paused background = block > +# operation for cancellation. It is an error to call this command if = no > +# operation is in progress. > +# > +# @device: the device name > +# > +# Returns: Nothing on success > +# If no background operation is active on this device, Device= NotActive > +# If cancellation already in progress, DeviceInUse > # > # Since: 1.1 1.2 Just so I'm clear, am I right that: calling block-job-pause multiple times means the subsequent calls are successful no-ops; likewise, calling block-job-resume on a job not paused (whether by calling multiple times, or if the job never paused in the first place) is a successful no-op. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigF9F7F222CAE584C7F1BA6FD5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP23HBAAoJEKeha0olJ0Nqp1gH+wSc4QsTKUNweqOzoPbu0lK8 /S8ICWMjcI51CpSBSapp1ffIu5G88hrZm8F6FhNDngm/cllmzmKc5SHN/3Frk+yh R+55sdgf66Irvdqzak1Wnf2yWDAuNH7L/t/T3pEK6MpS5p0yW9vLYDlHSJQI4LvX yoAgiQ7rLeeTdn/mAPBrQVWQTkMl51ZAau0jScUgriQkmzoZYgKjTh+0+s35e3QF Fdw67wSWGiv+f2UaZQ/1mgs8MW5UNWTK8X2PCY+YjUIaJL5UHYa4cYWm72o/r0xB 9wRBy+sQO2Uh9AVPs9PECrGEDIwve4nOSagpKmmmQnHKiiUSrdfBPGs4ibq8wCE= =2d8R -----END PGP SIGNATURE----- --------------enigF9F7F222CAE584C7F1BA6FD5--