From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sfaaf-00011J-0U for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:45:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sfaac-00011X-UB for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:45:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sfaac-000110-IF for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:45:42 -0400 Message-ID: <4FDB74B3.4080801@redhat.com> Date: Fri, 15 Jun 2012 11:45:23 -0600 From: Eric Blake MIME-Version: 1.0 References: <1339772759-31004-1-git-send-email-pbonzini@redhat.com> <1339772759-31004-13-git-send-email-pbonzini@redhat.com> In-Reply-To: <1339772759-31004-13-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig33DAD1A5350FE2E201555183" Subject: Re: [Qemu-devel] [RFC PATCH 12/36] block: sort BlockDeviceIoStatus errors by severity List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig33DAD1A5350FE2E201555183 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > +++ b/qapi-schema.json > @@ -429,7 +429,7 @@ > # > # Since: 1.0 > ## > -{ 'enum': 'BlockDeviceIoStatus', 'data': [ 'ok', 'failed', 'nospace' ]= } > +{ 'enum': 'BlockDeviceIoStatus', 'data': [ 'ok', 'nospace', 'failed' ]= } Isn't this an ABI change? Do we have any generated or client code where 'failed' mapping to 1 (pre-patch) vs. 2 (post-patch) would cause us back-compat grief? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig33DAD1A5350FE2E201555183 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP23SzAAoJEKeha0olJ0NqeF4H/jdzU1lpzmBsUDf4QdLKR8Ws +0176X3o8eq492osCdmzSSM8JcDULiXhQnDS+6dihDsZjYqO0DvU+M2p10zSP8V2 VRmLiqTFioYha1F4Yar1OYoNn34MzhsgGFPPFcxubAH7zaVi3mgtRU13sjnqmNMe oR9PGJ8Ga+/sYz1HR7VOwExdJ31V39WB3ELFIcK2ZX1shi3JVRiKgnl1czwdyT6/ QbSX/lUI1pPfzvYfJ201E1umQKAqz4m3/yL5KdoceYGvy8zmCen57LiAqn7z4veY vGAmxH+5i9vbM+tVEZ8LZIoyX82LvtLIp2UfFYuaK9Y8nFeIbcwdl3IaOYInDng= =PoKL -----END PGP SIGNATURE----- --------------enig33DAD1A5350FE2E201555183--