From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfadX-00025P-0M for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:48:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SfadV-00026c-AR for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:48:42 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:50815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfadV-00022i-6I for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:48:41 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 15 Jun 2012 13:48:37 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 8FE0B6E8053 for ; Fri, 15 Jun 2012 13:48:34 -0400 (EDT) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q5FHmXus230434 for ; Fri, 15 Jun 2012 13:48:34 -0400 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q5FHnR7M030724 for ; Fri, 15 Jun 2012 11:49:27 -0600 Message-ID: <4FDB756F.2060208@us.ibm.com> Date: Fri, 15 Jun 2012 12:48:31 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1338387301-10074-1-git-send-email-lcapitulino@redhat.com> <1338387301-10074-3-git-send-email-lcapitulino@redhat.com> <4FC74B1A.8080700@redhat.com> <20120531110608.4dc3fe22@doriath.home> <4FC77F6C.8000008@redhat.com> <20120531113127.1c8aa213@doriath.home> <4FC78637.4040605@redhat.com> <20120613144910.598bfe24@doriath.home> <4FDB6869.1000509@us.ibm.com> <4FDB6905.8050703@redhat.com> In-Reply-To: <4FDB6905.8050703@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Adding errno to QMP errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Kevin Wolf , armbru@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino On 06/15/2012 11:55 AM, Paolo Bonzini wrote: > Il 15/06/2012 18:52, Anthony Liguori ha scritto: >> Having an error like: >> >> { 'error': 'OpenFileFailed', 'file': 'filename', 'mode': 'r/w', >> 'os_error': 'enospc' } >> >> is actually pretty reasonable for something like a memory dump command >> where the user specifies a file. >> >> OTOH, for something complex like live snapshotting which many involve >> opening multiple files, it may not be good enough. >> >> So context is really everything here. > > I agree, though I think this is the least of the problems in reporting > errors from complex commands such as transaction. :) > > So I guess we can proceed with errno values, yuppy! Yes, but I reserve the right to nack abuses :-) Regards, Anthony Liguori > > Paolo >