From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54971)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Sfdjo-00047G-LT
	for qemu-devel@nongnu.org; Fri, 15 Jun 2012 17:07:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Sfdjm-0006pC-Ss
	for qemu-devel@nongnu.org; Fri, 15 Jun 2012 17:07:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35357)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Sfdjm-0006os-KU
	for qemu-devel@nongnu.org; Fri, 15 Jun 2012 17:07:22 -0400
Message-ID: <4FDBA3FD.5000106@redhat.com>
Date: Fri, 15 Jun 2012 15:07:09 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <20120615204648.9853.1225.sendpatchset@skannery.in.ibm.com>
	<20120615204701.9853.3126.sendpatchset@skannery.in.ibm.com>
In-Reply-To: <20120615204701.9853.3126.sendpatchset@skannery.in.ibm.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="------------enigB91AAB4E92524080C502B992"
Subject: Re: [Qemu-devel] [v1 Patch 1/10]Qemu: Enhance "info block" to
 display host cache setting
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Supriya Kannery <supriyak@linux.vnet.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Shrinidhi Joshi <spjoshi31@gmail.com>, Stefan Hajnoczi <stefanha@gmail.com>, Jeff Cody <jcody@redhat.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>, Christoph Hellwig <hch@lst.de>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigB91AAB4E92524080C502B992
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 06/15/2012 02:47 PM, Supriya Kannery wrote:
> Enhance "info block" to display hostcache setting for each
> block device.
>=20

>  ##
>  { 'type': 'BlockInfo',
>    'data': {'device': 'str', 'type': 'str', 'removable': 'bool',
> -           'locked': 'bool', '*inserted': 'BlockDeviceInfo',
> +           'locked': 'bool','hostcache': 'bool', '*inserted': 'BlockDe=
viceInfo',

space after comma

Since 'hostcache' was not present when talking to older qemu, should we
mark it optional?

--=20
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--------------enigB91AAB4E92524080C502B992
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBCAAGBQJP26P/AAoJEKeha0olJ0NqtIsH/1WaTaFYXJH8iLBZxo6AEV9H
WJkMjkpd5hwVzKMfhvHwsV4LflCgpmwozfCMIKihFFd10vv2Np6HOBdPEDK51TJI
ci+Ggqnnax+YjL3ajIhnZbAH3Ggq3n5rSjksV+Vi0tSX3JrLnAThdTKLe0Tvw8rC
IwoyVQfwmaSro2QNhyyhdcgQfvEju5UJOVsIHjNscEgUZ65cx0zcZ7Yx6xohyAiR
Jv6ZpPEoivfBm5l51ciZnrS2Fb6m2zvSxlBqCAwY5aymvHKxEy1KO1ho6qOWLp4B
NTmQyQDB41eqQX4cHPS0O8cRoDgXDVsQAkq9i0VO3c9lOerJIrEhyLICrZhW5pU=
=r7pv
-----END PGP SIGNATURE-----

--------------enigB91AAB4E92524080C502B992--