Re: [Qemu-devel] [RFC PATCH 25/36] mirror: add support for on_source_error/on_target_error

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1555 bytes --]

On 06/15/2012 09:05 AM, Paolo Bonzini wrote:
> (Mostly untested).
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  block/mirror.c   |   50 +++++++++++++++++++++++++++++++++++++++++---------
>  block_int.h      |    4 ++++
>  blockdev.c       |   14 ++++++++++++--
>  hmp.c            |    3 ++-
>  qapi-schema.json |    7 ++++++-
>  qmp-commands.hx  |    8 +++++++-
>  6 files changed, 72 insertions(+), 14 deletions(-)

> +++ b/qapi-schema.json
> @@ -1379,6 +1379,10 @@
>  #        (all the disk, only the sectors allocated in the topmost image, or
>  #        only new I/O).
>  #
> +# @on_source_error: #optional the action to take on an error on the source
> +#
> +# @on_target_error: #optional the action to take on an error on the target

Mention the default when not provided.

> +#
>  # Returns: nothing on success
>  #          If @device is not a valid block device, DeviceNotFound
>  #          If @target can't be opened, OpenFileFailed
> @@ -1389,7 +1393,8 @@
>  { 'command': 'drive-mirror',
>    'data': { 'device': 'str', 'target': 'str', '*format': 'str',
>              'sync': 'MirrorSyncMode', '*mode': 'NewImageMode',
> -            '*speed': 'int' } }
> +            '*speed': 'int', '*on_source_error': 'BlockdevOnError',
> +            '*on_target_error': 'BlockdevOnError' } }

QMP should prefer - over _; shouldn't this be '*on-source-error' and
'*on-target-error'?

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]