From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sfft2-0006r2-Pa for qemu-devel@nongnu.org; Fri, 15 Jun 2012 19:25:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sfft0-0003Kl-Hk for qemu-devel@nongnu.org; Fri, 15 Jun 2012 19:25:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45286) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sfft0-0003FW-9o for qemu-devel@nongnu.org; Fri, 15 Jun 2012 19:25:02 -0400 Message-ID: <4FDBC449.5000900@redhat.com> Date: Fri, 15 Jun 2012 17:24:57 -0600 From: Eric Blake MIME-Version: 1.0 References: <1339772759-31004-1-git-send-email-pbonzini@redhat.com> <1339772759-31004-37-git-send-email-pbonzini@redhat.com> In-Reply-To: <1339772759-31004-37-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig0C23F5F721199007FCC7768F" Subject: Re: [Qemu-devel] [RFC PATCH 36/36] mirror: allow customizing the granularity List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig0C23F5F721199007FCC7768F Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > The desired granularity may be very different depending on the kind of = operation > (e.g. continous replication vs. collapse-to-raw) and whether the VM is = expected > to perform lots of I/O while mirroring is in progress. Allow the user = to customize > it. > +++ b/qapi-schema.json > @@ -1383,6 +1383,8 @@ > # (all the disk, only the sectors allocated in the topmost imag= e, or > # only new I/O). > # > +# @granularity: #optional granularity of the dirty bitmap, default is = 64K. What happens if the user doesn't pass in a power of 2? Is there a minimum or maximum acceptable value? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig0C23F5F721199007FCC7768F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP28RJAAoJEKeha0olJ0Nq/EwH/R/eWIsLcYTl19smlbkH1JLV gvzvmC8xYIT0hN7+/iaSa1pqWBg2Bo4JZn8HTIpc/ab42LzcGkgfyyBeMtsAin5I qDWYV25izGI3eKrWTrVSofdy3JfIU5Qvr+GznRawFfvBkbp7ELZqhsalRILAM1Vh fStMvZub6ZHtphu6JW/HEf6KVhBLH+cnvWgZLwSyP/7PVj2FwE7WkWYjMk1wvmM5 t3CshONIF6HqlbDvZbnvHx0SasbO53/3sohBTXkD1gmfN2XzAYoBFYYBX3BT7vPV FS6kNYPbMzdlpERcsxEM3HA84Qd/mWTkEjvUZyjcVsLO7lBGaNLkpj2CNvkJk6I= =ilHv -----END PGP SIGNATURE----- --------------enig0C23F5F721199007FCC7768F--