qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michal Privoznik <mprivozn@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: libvir-list@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [libvirt] [PATCH 2/2] qemu_agent: Wait for events instead of agent response
Date: Sat, 16 Jun 2012 09:51:35 +0200	[thread overview]
Message-ID: <4FDC3B07.5090603@redhat.com> (raw)
In-Reply-To: <4FDB6E04.9000201@redhat.com>

On 15.06.2012 19:16, Eric Blake wrote:
> On 06/15/2012 10:10 AM, Michal Privoznik wrote:
>> With latest changes to qemu-ga success on some commands is not reported
>> anymore, e.g. guest-shutdown or guest-suspend-*. However, errors are
>> still being reported. Therefore, we need to find different source of
>> indication if operation was successful. Events.
>> ---
>>  src/qemu/qemu_agent.c   |   49 ++++++++++++++++++++++++++++++++++++++++++----
>>  src/qemu/qemu_agent.h   |    9 ++++++++
>>  src/qemu/qemu_process.c |    7 ++++++
>>  3 files changed, 60 insertions(+), 5 deletions(-)
>>
> 
>> @@ -1238,6 +1257,24 @@ error:
>>      return NULL;
>>  }
>>  
>> +void qemuAgentNotifyEvent(qemuAgentPtr mon,
>> +                          qemuAgentEvent event)
>> +{
>> +    VIR_DEBUG("mon=%p event=%d", mon, event);
>> +    if (mon->await_event == event) {
>> +        VIR_DEBUG("Wakening up a tragedian");
> 
> s/Wakening/Waking/
> 
> ACK.
> 
> 

Fixed and pushed. Thanks.

Michal

      reply	other threads:[~2012-06-16  7:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-15 16:10 [Qemu-devel] [PATCH 0/2] qemu_agent: Switch to event driven impl Michal Privoznik
2012-06-15 16:10 ` [Qemu-devel] [PATCH 1/2] qemu_agent: Add some more debug prints Michal Privoznik
2012-06-15 17:09   ` [Qemu-devel] [libvirt] " Eric Blake
2012-06-15 16:10 ` [Qemu-devel] [PATCH 2/2] qemu_agent: Wait for events instead of agent response Michal Privoznik
2012-06-15 17:16   ` [Qemu-devel] [libvirt] " Eric Blake
2012-06-16  7:51     ` Michal Privoznik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FDC3B07.5090603@redhat.com \
    --to=mprivozn@redhat.com \
    --cc=eblake@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).