From: Jan Kiszka <jan.kiszka@web.de>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Michael Tokarev <mjt@tls.msk.ru>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] kvm: align ram_size to page boundary
Date: Sun, 17 Jun 2012 13:03:29 +0200 [thread overview]
Message-ID: <4FDDB981.8070309@web.de> (raw)
In-Reply-To: <1339922831-23002-1-git-send-email-avi@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
On 2012-06-17 10:47, Avi Kivity wrote:
> kvm is not able to execute out of partial pages; align the RAM size
> so partial pages aren't present.
>
> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
> Signed-off-by: Avi Kivity <avi@redhat.com>
> ---
> kvm-all.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index 4ea7d85..482768f 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -1311,6 +1311,8 @@ int kvm_init(void)
>
> cpu_interrupt_handler = kvm_handle_interrupt;
>
> + ram_size = TARGET_PAGE_ALIGN(ram_size);
> +
> return 0;
>
> err:
I think this should rather go into generic code. What sense does it make
to have partial pages with TCG?
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-06-17 11:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-17 8:47 [Qemu-devel] [PATCH] kvm: align ram_size to page boundary Avi Kivity
2012-06-17 11:03 ` Jan Kiszka [this message]
2012-06-17 11:30 ` Avi Kivity
2012-06-17 11:47 ` Jan Kiszka
2012-06-17 11:51 ` Avi Kivity
2012-06-17 12:43 ` Blue Swirl
2012-06-17 12:48 ` Peter Maydell
2012-06-17 12:54 ` Avi Kivity
2012-06-17 13:06 ` Blue Swirl
2012-06-17 13:14 ` Avi Kivity
2012-07-06 18:50 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDDB981.8070309@web.de \
--to=jan.kiszka@web.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mjt@tls.msk.ru \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).