From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Michael Tokarev <mjt@tls.msk.ru>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] kvm: align ram_size to page boundary
Date: Sun, 17 Jun 2012 14:51:18 +0300 [thread overview]
Message-ID: <4FDDC4B6.5030202@redhat.com> (raw)
In-Reply-To: <4FDDC3C8.5020205@web.de>
On 06/17/2012 02:47 PM, Jan Kiszka wrote:
>>>
>>> I think this should rather go into generic code.
>>
>> To be honest, I put this in kvm-specific code because vl.c doesn't have
>> TARGET_PAGE_ALIGN. Maybe we should have machine->page_size or
>> machine->ram_alignment.
>>
>>> What sense does it make
>>> to have partial pages with TCG?
>>
>> Why impose an artificial restriction?
>
> Beca...
>
>>
>> (answer: to reduce differences among various accelerators)
>>
>
> Oh, you found the answer. :)
Reducing round-trips across the Internet.
>
> At least, it should be enforce for the x86 target, independent of the
> accelerator.
Yeah. So there's machine->page_size or machine->ram_alignment. Not
sure which is best.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-06-17 12:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-17 8:47 [Qemu-devel] [PATCH] kvm: align ram_size to page boundary Avi Kivity
2012-06-17 11:03 ` Jan Kiszka
2012-06-17 11:30 ` Avi Kivity
2012-06-17 11:47 ` Jan Kiszka
2012-06-17 11:51 ` Avi Kivity [this message]
2012-06-17 12:43 ` Blue Swirl
2012-06-17 12:48 ` Peter Maydell
2012-06-17 12:54 ` Avi Kivity
2012-06-17 13:06 ` Blue Swirl
2012-06-17 13:14 ` Avi Kivity
2012-07-06 18:50 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDDC4B6.5030202@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=mjt@tls.msk.ru \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).