From: Anthony Liguori <anthony@codemonkey.ws>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "'qemu-devel@nongnu.org'" <qemu-devel@nongnu.org>,
"Ma, Stephen B." <stephen.ma@hp.com>
Subject: Re: [Qemu-devel] [PATCH] Fix for qemu crash on assertion error when adding PCI passthru device.
Date: Sun, 17 Jun 2012 09:28:04 -0500 [thread overview]
Message-ID: <4FDDE974.3040001@codemonkey.ws> (raw)
In-Reply-To: <20120617083427.GB28089@redhat.com>
On 06/17/2012 03:34 AM, Michael S. Tsirkin wrote:
> On Sun, Jun 17, 2012 at 06:26:33AM +0000, Ma, Stephen B. wrote:
>>
>> Michael,
>>
>> Thanks for the review. I added the unparent to the qdev_free.
>>
>>
>> ---
>> hw/qdev.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/qdev.c b/hw/qdev.c
>> index d2dc28b..ed1328d 100644
>> --- a/hw/qdev.c
>> +++ b/hw/qdev.c
>> @@ -264,6 +264,7 @@ void qdev_init_nofail(DeviceState *dev)
>> /* Unlink device from bus and free the structure. */
>> void qdev_free(DeviceState *dev)
>> {
>> + object_unparent(OBJECT(dev));
>> object_delete(OBJECT(dev));
>> }
>>
>> --
>> 1.7.1
>
> Anthony, any feedback?
Yes, this is wrong.
PCI passthrough isn't in qemu.git so it's not clear to me where this is
happening. Why would qdev_free be called when adding a PCI passthru device?
Regards,
Anthony Liguori
>
next prev parent reply other threads:[~2012-06-17 14:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 4:31 [Qemu-devel] [PATCH] Fix for qemu crash on assertion error when adding PCI passthru device Ma, Stephen B.
2012-06-12 8:26 ` Michael S. Tsirkin
2012-06-17 6:26 ` Ma, Stephen B.
2012-06-17 8:34 ` Michael S. Tsirkin
2012-06-17 14:28 ` Anthony Liguori [this message]
2012-06-18 6:24 ` Jan Kiszka
2012-07-18 20:42 ` Ma, Stephen B.
2012-07-19 6:27 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDDE974.3040001@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stephen.ma@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).