From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34186)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SgGSa-0004FC-DI
	for qemu-devel@nongnu.org; Sun, 17 Jun 2012 10:28:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SgGSY-0006Tq-MT
	for qemu-devel@nongnu.org; Sun, 17 Jun 2012 10:28:11 -0400
Received: from mail-ob0-f173.google.com ([209.85.214.173]:34886)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SgGSY-0006Tj-Hb
	for qemu-devel@nongnu.org; Sun, 17 Jun 2012 10:28:10 -0400
Received: by obbwd20 with SMTP id wd20so7502146obb.4
	for <qemu-devel@nongnu.org>; Sun, 17 Jun 2012 07:28:08 -0700 (PDT)
Message-ID: <4FDDE974.3040001@codemonkey.ws>
Date: Sun, 17 Jun 2012 09:28:04 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <36AF4B62444F4B4FB04EDD1FDAE1CF1D4889875E@G4W3209.americas.hpqcorp.net>
	<20120612082641.GC12356@redhat.com>
	<36AF4B62444F4B4FB04EDD1FDAE1CF1D48899822@G4W3209.americas.hpqcorp.net>
	<20120617083427.GB28089@redhat.com>
In-Reply-To: <20120617083427.GB28089@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Fix for qemu crash on assertion error when
 adding PCI passthru device.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "'qemu-devel@nongnu.org'" <qemu-devel@nongnu.org>, "Ma,
	Stephen B." <stephen.ma@hp.com>

On 06/17/2012 03:34 AM, Michael S. Tsirkin wrote:
> On Sun, Jun 17, 2012 at 06:26:33AM +0000, Ma, Stephen B. wrote:
>>
>> Michael,
>>
>> Thanks for the review.  I added the unparent to the qdev_free.
>>
>>
>> ---
>>   hw/qdev.c |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/qdev.c b/hw/qdev.c
>> index d2dc28b..ed1328d 100644
>> --- a/hw/qdev.c
>> +++ b/hw/qdev.c
>> @@ -264,6 +264,7 @@ void qdev_init_nofail(DeviceState *dev)
>>   /* Unlink device from bus and free the structure.  */
>>   void qdev_free(DeviceState *dev)
>>   {
>> +    object_unparent(OBJECT(dev));
>>       object_delete(OBJECT(dev));
>>   }
>>
>> --
>> 1.7.1
>
> Anthony, any feedback?

Yes, this is wrong.

PCI passthrough isn't in qemu.git so it's not clear to me where this is 
happening.  Why would qdev_free be called when adding a PCI passthru device?

Regards,

Anthony Liguori

>