From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57741)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SgKV3-0005oi-GQ
	for qemu-devel@nongnu.org; Sun, 17 Jun 2012 14:47:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SgKV1-0003Sy-P2
	for qemu-devel@nongnu.org; Sun, 17 Jun 2012 14:47:01 -0400
Received: from mail-ob0-f173.google.com ([209.85.214.173]:40107)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SgKV1-0003SX-KA
	for qemu-devel@nongnu.org; Sun, 17 Jun 2012 14:46:59 -0400
Received: by obbwd20 with SMTP id wd20so7779908obb.4
	for <qemu-devel@nongnu.org>; Sun, 17 Jun 2012 11:46:57 -0700 (PDT)
Message-ID: <4FDE261F.60502@codemonkey.ws>
Date: Sun, 17 Jun 2012 13:46:55 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1339945072-10816-1-git-send-email-aliguori@us.ibm.com>
	<CAAu8pHss3=TRaWgD=V0-uO1GO9Rph8SdY3Yj2BsdJHMYecA0Cw@mail.gmail.com>
	<4FDE046E.3090407@suse.de> <4FDE0D1E.7030308@suse.de>
In-Reply-To: <4FDE0D1E.7030308@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] make: automatically include dependencies
 in recursive subdir rules
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On 06/17/2012 12:00 PM, Andreas Färber wrote:
> Am 17.06.2012 18:23, schrieb Andreas Färber:
>> I've tested with just
>> +$(eval -include $(wildcard $1/*.d))
>> and did
>> $ touch include/qemu/object.h
>>
>>  From what I see, using Anthony's original patch plus the modification
>> above (not the other ones), {i386,x86_64}-softmmu/hw/kvm/apic.o is still
>> not getting rebuilt despite its included hw/apic_internal.h depending on
>> sysbus.h ->  qdev.h ->  qemu/object.h.
>>
>> They're being added via obj-$(CONFIG_KVM) += kvm/filename.o, not via the
>> recursive directory rule, so are not caught by Anthony's rule.
>>
>> Maybe fix by some explicit Makefile-specific rule such as this?
>>
>> diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs
>> index d43f1df..1e8423a 100644
>> --- a/hw/i386/Makefile.objs
>> +++ b/hw/i386/Makefile.objs
>> @@ -11,3 +11,5 @@ obj-$(CONFIG_KVM) += kvm/clock.o kvm/apic.o
>> kvm/i8259.o kvm/ioapic.o kvm/i8254.o
>>   obj-$(CONFIG_SPICE) += qxl.o qxl-logger.o qxl-render.o
>>
>>   obj-y := $(addprefix ../,$(obj-y))
>> +
>> +-include $(wildcard ../kvm/*.d)
>
> If using hw/kvm/*.d instead, it actually works. ;)

We can also just add a hw/kvm/Makefile.objs and then add kvm/ to the subdir 
rules.  Seems to fix the problem you identified.

Just doing a full build for v2.  Will send out when it completes.

Regards,

Anthony Liguori

>
> Andreas
>