From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34021)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SgPUe-0005L6-2g
	for qemu-devel@nongnu.org; Sun, 17 Jun 2012 20:06:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SgPUc-0002gG-6r
	for qemu-devel@nongnu.org; Sun, 17 Jun 2012 20:06:55 -0400
Received: from mail-pz0-f45.google.com ([209.85.210.45]:56472)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SgPUb-0002g6-VY
	for qemu-devel@nongnu.org; Sun, 17 Jun 2012 20:06:54 -0400
Received: by dadn2 with SMTP id n2so5569193dad.4
	for <qemu-devel@nongnu.org>; Sun, 17 Jun 2012 17:06:52 -0700 (PDT)
Message-ID: <4FDE7118.7060909@codemonkey.ws>
Date: Sun, 17 Jun 2012 19:06:48 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1339945072-10816-1-git-send-email-aliguori@us.ibm.com>
	<CAAu8pHss3=TRaWgD=V0-uO1GO9Rph8SdY3Yj2BsdJHMYecA0Cw@mail.gmail.com>
	<4FDE046E.3090407@suse.de> <4FDE0D1E.7030308@suse.de>
	<4FDE261F.60502@codemonkey.ws> <4FDE35D4.2050109@suse.de>
In-Reply-To: <4FDE35D4.2050109@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] make: automatically include dependencies
 in recursive subdir rules
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On 06/17/2012 02:53 PM, Andreas Färber wrote:
> Am 17.06.2012 20:46, schrieb Anthony Liguori:
>> On 06/17/2012 12:00 PM, Andreas Färber wrote:
>>> If using hw/kvm/*.d instead, it actually works. ;)
>>
>> We can also just add a hw/kvm/Makefile.objs and then add kvm/ to the
>> subdir rules.  Seems to fix the problem you identified.
>
> No, that would be wrong wrt ppc/s390/arm. But we could move the files
> from hw/kvm/ to hw/i386/.

Hrm, no, I don't think that's necessary.

Look at v2 of my patch.  kvm/ is only added by target hw makefiles 
(hw/i386/Makefile.objs).  So these devices are only even attempted to be added 
for i386.

Then within kvm/Makefile.objs, everything is guarded with CONFIG_KVM.

I think a better approach would be to:

hw/Makefiles.obj:
   obj-$(CONFIG_KVM) += kvm/

hw/kvm/Makefiles.obj:
   obj-$(CONFIG_I386) += apic.o pit.o ...

That way there could be ppc-specific KVM devices.

But that's a bigger refactoring as these devices need to be built target-specific.

Regards,

Anthony Liguori

>
> Andreas
>