From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SgZPV-0004pu-W5 for qemu-devel@nongnu.org; Mon, 18 Jun 2012 06:42:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SgZPN-0004Mx-Tw for qemu-devel@nongnu.org; Mon, 18 Jun 2012 06:42:17 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58590 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SgZPN-0004Mf-NN for qemu-devel@nongnu.org; Mon, 18 Jun 2012 06:42:09 -0400 Message-ID: <4FDF05FC.1060107@suse.de> Date: Mon, 18 Jun 2012 12:42:04 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1339977692-3196-1-git-send-email-aliguori@us.ibm.com> <4FDE7711.201@suse.de> <4FDEF152.2070303@siemens.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] make: automatically include dependencies in recursive subdir rules (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Jan Kiszka , Anthony Liguori , "qemu-devel@nongnu.org" , Paolo Bonzini Am 18.06.2012 11:31, schrieb Peter Maydell: > On 18 June 2012 10:13, Jan Kiszka wrote: >> On 2012-06-18 02:32, Andreas F=C3=A4rber wrote: >>> This will work technically but I still feel this is wrong semanticall= y. >>> The pre-Paolo and current way is picking specific files from the hw/k= vm/ >>> directory. Your change above implies that in hw/kvm/ only x86 files c= an >>> live, which I dislike. >=20 >> Some per-arch separation is required, at least in the build process. >> We'll see power and arm stubs for in-kernel devices soon. >=20 > Indeed -- I have a hw/kvm/arm_gic.c in the qemu-linaro tree, so > if you break building that I'll have to unbreak it :-) >=20 > (Does architecture-specific separation make much sense in general? > Not all devices are architecture-specific. I'd have thought that > a functional split eg timer/serial/usb like the linux kernel layout > would be better.) Maybe you're misreading me? I was saying iff a device is specifically (not accidentally) for one target foo then it may/should be placed into hw/foo/ directory. We already have a hw/usb/ directory, and as long as there are no target dependencies and sufficient files I see nothing wrong with hw/timer/ or hw/serial/. Cheers, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg