From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47105) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SgaFQ-0004FC-7J for qemu-devel@nongnu.org; Mon, 18 Jun 2012 07:36:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SgaFJ-0001JM-BS for qemu-devel@nongnu.org; Mon, 18 Jun 2012 07:35:55 -0400 Received: from cantor2.suse.de ([195.135.220.15]:33898 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SgaFI-0001JA-Vv for qemu-devel@nongnu.org; Mon, 18 Jun 2012 07:35:49 -0400 Message-ID: <4FDF128C.2050909@suse.de> Date: Mon, 18 Jun 2012 13:35:40 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1339977692-3196-1-git-send-email-aliguori@us.ibm.com> <4FDE7711.201@suse.de> <4FDEF152.2070303@siemens.com> <4FDF05FC.1060107@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] make: automatically include dependencies in recursive subdir rules (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Jan Kiszka , Anthony Liguori , "qemu-devel@nongnu.org" , Paolo Bonzini Am 18.06.2012 12:56, schrieb Peter Maydell: > On 18 June 2012 11:42, Andreas F=C3=A4rber wrote: >> Am 18.06.2012 11:31, schrieb Peter Maydell: >>> (Does architecture-specific separation make much sense in general? >>> Not all devices are architecture-specific. I'd have thought that >>> a functional split eg timer/serial/usb like the linux kernel layout >>> would be better.) >> >> Maybe you're misreading me? I was saying iff a device is specifically >> (not accidentally) for one target foo then it may/should be placed int= o >> hw/foo/ directory. >=20 > Yes, I'm saying that seems like a confusing split, because a few > devices for target foo will be in hw/foo and a number more in hw/, > and there'll probably be cases where something in hw/foo has to > move out into hw/ when a new target comes along that happens to > reuse it. So rather than having hw/foo where foo =3D=3D target-name, > I'm suggesting hw/foo where foo =3D=3D kind-of-device. As you say > we've already moved a bit down this road with usb, for instance. But the point is that hw/foo/ is required for the new Makefile system, so we have the empty folders anyway, whereas putting target-specific stuff into, e.g., hw/apic/ will not solve the dependency issue that I tracked down here. If you do have an automated solution to that, please spill it out. :) Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg