From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SgbMX-0001DL-Uq for qemu-devel@nongnu.org; Mon, 18 Jun 2012 08:47:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SgbMP-00012L-A4 for qemu-devel@nongnu.org; Mon, 18 Jun 2012 08:47:21 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:57563) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SgbMP-00011m-4K for qemu-devel@nongnu.org; Mon, 18 Jun 2012 08:47:13 -0400 Received: from /spool/local by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 18 Jun 2012 06:47:07 -0600 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 47264C90062 for ; Mon, 18 Jun 2012 08:47:04 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q5ICl5CV193244 for ; Mon, 18 Jun 2012 08:47:05 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q5IIHuvf001769 for ; Mon, 18 Jun 2012 14:17:56 -0400 Message-ID: <4FDF2346.9060504@us.ibm.com> Date: Mon, 18 Jun 2012 07:47:02 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1339977692-3196-1-git-send-email-aliguori@us.ibm.com> <4FDE7711.201@suse.de> <4FDEF152.2070303@siemens.com> In-Reply-To: <4FDEF152.2070303@siemens.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] make: automatically include dependencies in recursive subdir rules (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Paolo Bonzini , =?ISO-8859-15?Q?Andreas_F=E4rber?= , "qemu-devel@nongnu.org" On 06/18/2012 04:13 AM, Jan Kiszka wrote: > On 2012-06-18 02:32, Andreas Färber wrote: >> Am 18.06.2012 02:01, schrieb Anthony Liguori: >> This will work technically but I still feel this is wrong semantically. >> The pre-Paolo and current way is picking specific files from the hw/kvm/ >> directory. Your change above implies that in hw/kvm/ only x86 files can >> live, which I dislike. As suggested before, I would prefer if x86-only >> files were moved to an x86-specific location - the place for that >> existing since Paolo's refactoring would be hw/i386/. CC'ing Jan. That >> would match Paolo's reply in the unicore32 thread on future file >> placement. Alternatives would be hw/i386/kvm/ or hw/kvm/i386/; we're >> talking about a handful of files only though, so I don't think they >> require a new subdirectory. > > Some per-arch separation is required, at least in the build process. > We'll see power and arm stubs for in-kernel devices soon. i8259.o i8254.o ioapic.o don't need to be arch specific apic.o ought to be renamed to lapic.o and moved to target-i386/kvm/ I think clock.o also more than likely belongs in target-i386/kvm/. It would have to be implemented as part of the CPU core if it ever existed IRL. In general, if is logically part of a CPU core, it ought to be in target-$(ARCH). Otherwise, it shouldn't be built as a target specific object. Regards, Anthony Liguori > Jan >