From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sgbgu-0006vr-CG for qemu-devel@nongnu.org; Mon, 18 Jun 2012 09:08:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sgbgo-0007A7-1a for qemu-devel@nongnu.org; Mon, 18 Jun 2012 09:08:23 -0400 Received: from thoth.sbs.de ([192.35.17.2]:19938) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sgbgn-00079g-P5 for qemu-devel@nongnu.org; Mon, 18 Jun 2012 09:08:17 -0400 Message-ID: <4FDF283D.1010201@siemens.com> Date: Mon, 18 Jun 2012 15:08:13 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1339977692-3196-1-git-send-email-aliguori@us.ibm.com> <4FDE7711.201@suse.de> <4FDEF152.2070303@siemens.com> <4FDF2346.9060504@us.ibm.com> In-Reply-To: <4FDF2346.9060504@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] make: automatically include dependencies in recursive subdir rules (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Paolo Bonzini , =?ISO-8859-15?Q?Andreas_F=E4rber?= , "qemu-devel@nongnu.org" On 2012-06-18 14:47, Anthony Liguori wrote: > On 06/18/2012 04:13 AM, Jan Kiszka wrote: >> On 2012-06-18 02:32, Andreas F=E4rber wrote: >>> Am 18.06.2012 02:01, schrieb Anthony Liguori: >>> This will work technically but I still feel this is wrong semanticall= y. >>> The pre-Paolo and current way is picking specific files from the hw/k= vm/ >>> directory. Your change above implies that in hw/kvm/ only x86 files c= an >>> live, which I dislike. As suggested before, I would prefer if x86-onl= y >>> files were moved to an x86-specific location - the place for that >>> existing since Paolo's refactoring would be hw/i386/. CC'ing Jan. Tha= t >>> would match Paolo's reply in the unicore32 thread on future file >>> placement. Alternatives would be hw/i386/kvm/ or hw/kvm/i386/; we're >>> talking about a handful of files only though, so I don't think they >>> require a new subdirectory. >> >> Some per-arch separation is required, at least in the build process. >> We'll see power and arm stubs for in-kernel devices soon. >=20 > i8259.o i8254.o ioapic.o don't need to be arch specific In theory. In practice they carry quite a bit of the PC architecture (i8254: HPET and PC speaker port, i8259: ELCR). Maybe not the IOAPIC. It was once reused on IA64, but that arch is dead. >=20 > apic.o ought to be renamed to lapic.o and moved to target-i386/kvm/ "apic" is fine as name as the code covers both cases. Should be move hw/apic* as well? >=20 > I think clock.o also more than likely belongs in target-i386/kvm/. It = would=20 > have to be implemented as part of the CPU core if it ever existed IRL. >=20 > In general, if is logically part of a CPU core, it ought to be in=20 > target-$(ARCH). Otherwise, it shouldn't be built as a target specific = object. There are some practical things like lacking types or defines in the KVM API that most probably prevent building certain KVM devices for all targets unconditionally. Jan --=20 Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux