From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sgbk4-0000A1-FK for qemu-devel@nongnu.org; Mon, 18 Jun 2012 09:11:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sgbjx-0008AG-Mk for qemu-devel@nongnu.org; Mon, 18 Jun 2012 09:11:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53273) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sgbjx-0008A2-F5 for qemu-devel@nongnu.org; Mon, 18 Jun 2012 09:11:33 -0400 Message-ID: <4FDF28FB.7090701@redhat.com> Date: Mon, 18 Jun 2012 15:11:23 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1340024457-27306-1-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1340024457-27306-1-git-send-email-stefanha@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qcow2: preserve free_byte_offset when qcow2_alloc_bytes() fails List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org Am 18.06.2012 15:00, schrieb Stefan Hajnoczi: > When qcow2_alloc_clusters() error handling code was introduced in commit > 5d757b563d59142ca81e1073a8e8396750a0ad1a, the value of free_byte_offset > was clobbered in the error case. This patch keeps free_byte_offset at 0 > so we will try to allocate clusters again next time this function is > called. > > Signed-off-by: Stefan Hajnoczi Thanks, applied to the block branch. And I guess we should get test case 026 fixed up and extended to cover this. Kevin