From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53298) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sgt2N-0002d7-ES for qemu-devel@nongnu.org; Tue, 19 Jun 2012 03:39:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sgt2K-00039z-8r for qemu-devel@nongnu.org; Tue, 19 Jun 2012 03:39:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32525) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sgt2K-00039o-0m for qemu-devel@nongnu.org; Tue, 19 Jun 2012 03:39:40 -0400 Message-ID: <4FE02CB6.9090006@redhat.com> Date: Tue, 19 Jun 2012 09:39:34 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1338387301-10074-1-git-send-email-lcapitulino@redhat.com> <1338387301-10074-3-git-send-email-lcapitulino@redhat.com> <4FC74B1A.8080700@redhat.com> <20120531110608.4dc3fe22@doriath.home> <4FC77F6C.8000008@redhat.com> <20120531113127.1c8aa213@doriath.home> <4FC78637.4040605@redhat.com> <20120613144910.598bfe24@doriath.home> <4FDB6869.1000509@us.ibm.com> <20120615170350.GO16777@redhat.com> <4FDF7418.9070206@codemonkey.ws> In-Reply-To: <4FDF7418.9070206@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Adding errno to QMP errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Anthony Liguori , qemu-devel@nongnu.org, Markus Armbruster , Luiz Capitulino , Paolo Bonzini Am 18.06.2012 20:31, schrieb Anthony Liguori: > Irrespective of anything else, I think it's safe to say the experiment of "rich > errors" has been a failure. We still have way too many places using error_report. > > As I mentioned in another thread, I think we should: > > 1) Introduce a GENERIC_ERROR QError type. It could have a 'domain' and a 'msg' > field. > > 2) Focus on converting users of error_report over to use propagated Error objects. > > We shouldn't/can't change existing QError users. We also shouldn't consider > changing the wire protocol. But for new error users, we should/can relax the > reported errors. > > We need a clear support policy on whether the contents of 'msg' are stable or > not too. Another point that you used to bring up in earlier discussions is translated error messages. If we start returning error messages that are meant to displayed to the user, should we get your gettext patches applied which you did for the GTK backend? libvirt would then have to pay attention to start qemu with the same locale as the client has. Kevin